summaryrefslogtreecommitdiffstats
path: root/heal
diff options
context:
space:
mode:
authorAnuradha <atalur@redhat.com>2014-12-30 18:54:33 +0530
committerPranith Kumar Karampuri <pkarampu@redhat.com>2015-01-01 21:55:04 -0800
commita96375c180901756753246cb00b42f44fd8b4fd7 (patch)
treeb83139fa8baa3015175d4b9b6b976290c63e3339 /heal
parentc8263975862afa9e5afc603bf2d05ab93087bcc4 (diff)
afr: Fixes to commit 85427a23c238499137cbfaafdb7b6ad27f67506a
* Fixed a dict leak * Re-added 'return on failure' check Change-Id: I07edd03e4608fd2b7c4a91019a0e43033e6e78b2 BUG: 1163804 Signed-off-by: Anuradha <atalur@redhat.com> Reviewed-on: http://review.gluster.org/9368 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com> Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Diffstat (limited to 'heal')
-rw-r--r--heal/src/glfs-heal.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/heal/src/glfs-heal.c b/heal/src/glfs-heal.c
index f1249ec6670..c52a46bd709 100644
--- a/heal/src/glfs-heal.c
+++ b/heal/src/glfs-heal.c
@@ -206,6 +206,10 @@ glfsh_process_entries (xlator_t *xl, fd_t *fd, gf_dirent_t *entries,
(strcmp (entry->d_name, "..") == 0))
continue;
+ if (dict) {
+ dict_unref (dict);
+ dict = NULL;
+ }
uuid_clear (gfid);
GF_FREE (path);
path = NULL;
@@ -229,6 +233,10 @@ glfsh_process_entries (xlator_t *xl, fd_t *fd, gf_dirent_t *entries,
}
ret = 0;
GF_FREE (path);
+ if (dict) {
+ dict_unref (dict);
+ dict = NULL;
+ }
return ret;
}