diff options
| author | Atin Mukherjee <amukherj@redhat.com> | 2017-05-03 12:17:30 +0530 | 
|---|---|---|
| committer | Raghavendra Talur <rtalur@redhat.com> | 2017-05-10 10:42:07 +0000 | 
| commit | 68047830e46f1ee2bd17d16ca6206cd0123e1ed2 (patch) | |
| tree | dafa13082de8ff05275f8db31bc40746da7a19f0 /glusterfsd | |
| parent | 38496dd45780e651647c294b782268557ce31836 (diff) | |
glusterd: cleanup pidfile on pmap signout
This patch ensures
1. brick pidfile is cleaned up on pmap signout
2. pmap signout evemt is sent for all the bricks when a brick process
shuts down.
>Reviewed-on: https://review.gluster.org/17168
>Smoke: Gluster Build System <jenkins@build.gluster.org>
>NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
>CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
>Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
>(cherry picked from commit 3d35e21ffb15713237116d85711e9cd1dda1688a)
Change-Id: I7606a60775b484651d4b9743b6037b40323931a2
BUG: 1449002
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17209
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Diffstat (limited to 'glusterfsd')
| -rw-r--r-- | glusterfsd/src/glusterfsd.c | 18 | 
1 files changed, 17 insertions, 1 deletions
diff --git a/glusterfsd/src/glusterfsd.c b/glusterfsd/src/glusterfsd.c index 41515fe12e7..dd89c47ff43 100644 --- a/glusterfsd/src/glusterfsd.c +++ b/glusterfsd/src/glusterfsd.c @@ -1303,6 +1303,9 @@ cleanup_and_exit (int signum)  {          glusterfs_ctx_t *ctx      = NULL;          xlator_t        *trav     = NULL; +        xlator_t        *top; +        xlator_t        *victim; +        xlator_list_t   **trav_p;          ctx = glusterfsd_ctx; @@ -1332,7 +1335,20 @@ cleanup_and_exit (int signum)                  return;          ctx->cleanup_started = 1; -        glusterfs_mgmt_pmap_signout (ctx, NULL); + +        /* signout should be sent to all the bricks in case brick mux is enabled +         * and multiple brick instances are attached to this process +         */ +        if (ctx->active) { +                top = ctx->active->first; +                for (trav_p = &top->children; *trav_p; +                     trav_p = &(*trav_p)->next) { +                        victim = (*trav_p)->xlator; +                        glusterfs_mgmt_pmap_signout (ctx, victim->name); +                } +        } else { +                glusterfs_mgmt_pmap_signout (ctx, NULL); +        }          /* below part is a racy code where the rpcsvc object is freed.           * But in another thread (epoll thread), upon poll error in the  | 
