summaryrefslogtreecommitdiffstats
path: root/glusterfsd/src
diff options
context:
space:
mode:
authorShyamsundarR <srangana@redhat.com>2018-08-06 19:40:30 -0400
committerAmar Tumballi <amarts@redhat.com>2018-08-13 12:45:50 +0000
commitbd35aa2aa34c9bd2269aa225f83a404a58b81a21 (patch)
tree93f7f130603dd0fe11ec4afe1f04007c410f9a5a /glusterfsd/src
parent93c9062ccdf6a5b0461e2ea10ebe8d54d364a243 (diff)
coverity: last of the secure temp fixes
Coverity ignore directive is not working if the comment is split across lines (or has an empty line at the end. This can be seen in this report: https://download.gluster.org/pub/gluster/glusterfs/static-analysis /master/glusterfs-coverity/2018-08-06-b982e09f/html/1 /384glusterfsd-mgmt.c.html#error In other places the same pattern has avoided coverity from flagging off the same call, except here. Updates: bz#789278 Change-Id: Ic35ff0fc91d0a42904630728ef7c18215aa277f3 Signed-off-by: ShyamsundarR <srangana@redhat.com>
Diffstat (limited to 'glusterfsd/src')
-rw-r--r--glusterfsd/src/glusterfsd-mgmt.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/glusterfsd/src/glusterfsd-mgmt.c b/glusterfsd/src/glusterfsd-mgmt.c
index bf56bc0abfa..df9a05c75f0 100644
--- a/glusterfsd/src/glusterfsd-mgmt.c
+++ b/glusterfsd/src/glusterfsd-mgmt.c
@@ -1992,9 +1992,7 @@ volfile:
}
}
- /* coverity[secure_temp] mkstemp uses 0600 as the mode and is
- * safe
- */
+ /* coverity[secure_temp] mkstemp uses 0600 as the mode */
tmp_fd = mkstemp (template);
if (-1 == tmp_fd) {
gf_msg (frame->this->name, GF_LOG_ERROR, 0,