diff options
| author | Jeff Darcy <jdarcy@redhat.com> | 2016-07-25 09:05:20 -0400 |
|---|---|---|
| committer | Vijay Bellur <vbellur@redhat.com> | 2016-07-26 07:50:16 -0700 |
| commit | 934cae8781bf04f086f8302ef88542ee6604a576 (patch) | |
| tree | bc3fe5f997a6e1eb8134d84c8ffa2ec9d017b91c /extras/checkpatch.pl | |
| parent | d2bd17e5a53d0ffa375df1a5ad957556be2f2b83 (diff) | |
infra: remove anti-typedef check
Linus's dislike of typedefs is one of his most idiosyncratic positions,
at odds with the mainstream of software engineering and practice.
There's no reason that quirk should have been imposed on this project,
which was done by fiat when we adopted a style checker written for a
very different audience and environment.
Change-Id: Ic08b0d14a0130ee88c3f60dcac07670d91004c2b
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/15004
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Diffstat (limited to 'extras/checkpatch.pl')
| -rwxr-xr-x | extras/checkpatch.pl | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/extras/checkpatch.pl b/extras/checkpatch.pl index dee070c8c7c..205567307b1 100755 --- a/extras/checkpatch.pl +++ b/extras/checkpatch.pl @@ -2634,17 +2634,6 @@ sub process { } } -# check for new typedefs, only function parameters and sparse annotations -# make sense. - if ($line =~ /\btypedef\s/ && - $line !~ /\btypedef\s+$Type\s*\(\s*\*?$Ident\s*\)\s*\(/ && - $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ && - $line !~ /\b$typeTypedefs\b/ && - $line !~ /\b__bitwise(?:__|)\b/) { - WARN("NEW_TYPEDEFS", - "do not add new typedefs\n" . $herecurr); - } - # * goes on variable not on type # (char*[ const]) while ($line =~ m{(\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\))}g) { |