summaryrefslogtreecommitdiffstats
path: root/contrib/umountd/umountd.c
diff options
context:
space:
mode:
authorYaniv Kaul <ykaul@redhat.com>2018-08-21 18:31:03 +0300
committerAmar Tumballi <amarts@redhat.com>2018-08-24 16:26:36 +0000
commita2c562eb4046ce88c8c2f2d250b0079942e7f10a (patch)
tree64e6733e2407126f546c824c474027f1a0540f81 /contrib/umountd/umountd.c
parent938849a417727c85f1925dde641b3c6c54c71275 (diff)
{mount-common|fusermount|mount_darwin|umountd}.c: strncpy()->sprintf(), reduce strlen()'s
strncpy may not be very efficient for short strings copied into a large buffer: If the length of src is less than n, strncpy() writes additional null bytes to dest to ensure that a total of n bytes are written. Instead, use snprintf(). Also: - save the result of strlen() and re-use it when possible. - move from strlen to SLEN (sizeof() ) for const strings. Compile-tested only! Change-Id: I369209b36d8356c3fe00d32f8bf56e74cf9963db updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Diffstat (limited to 'contrib/umountd/umountd.c')
-rw-r--r--contrib/umountd/umountd.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/umountd/umountd.c b/contrib/umountd/umountd.c
index c06dd54db6e..6b9e3c43031 100644
--- a/contrib/umountd/umountd.c
+++ b/contrib/umountd/umountd.c
@@ -66,7 +66,7 @@ sanity_check (char *path, dev_t *devp)
if (*devp == -1 && ret == 0)
*devp = st.st_dev;
- strncpy (pathtmp, path, PATH_MAX);
+ snprintf (pathtmp, PATH_MAX, "%s", path);
parent = dirname (pathtmp);
if (stat (parent, &parent_st) != 0) {