diff options
author | Aravinda VK <avishwan@redhat.com> | 2016-06-23 11:53:36 +0530 |
---|---|---|
committer | Aravinda VK <avishwan@redhat.com> | 2016-08-31 22:58:23 -0700 |
commit | 26b4f38176d15f996b809511ce1adf5f0ea8234e (patch) | |
tree | 3eb168fb910298f3328a70daf66f17d116d201e0 /cli | |
parent | ecb8d38d34c6cdd16e34bbe40d3e64e9d1cc9909 (diff) |
geo-rep: Handle Config parser errors
Python ConfigParser lib has two methods, readfp and read, it should
be used as follows.
readfp(open("defaults.conf"))
read("custom.conf")
ConfigParser.read(path) ignores any file errors, which is intentional
since errors are handled while loading default config.
Geo-rep uses only one config file(Session config in Master side and
Template config on Slave side) so we should use readfp to avoid
skipping OS errors.
config.read is retained in case of `--config-set-rx` where glusterd
creates new template config file.
> Signed-off-by: Aravinda VK <avishwan@redhat.com>
> Reviewed-on: http://review.gluster.org/14777
> Smoke: Gluster Build System <jenkins@build.gluster.org>
> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
> Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
(cherry picked from commit d94bf608b16b82f2c8f8588a96459cb746773b32)
BUG: 1357760
Change-Id: I15a14d3743facd7b8c7af0edc70fdefaa43efd04
Signed-off-by: Aravinda VK <avishwan@redhat.com>
Reviewed-on: http://review.gluster.org/14947
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Diffstat (limited to 'cli')
0 files changed, 0 insertions, 0 deletions