diff options
| author | Pranith Kumar K <pkarampu@redhat.com> | 2016-10-18 15:16:17 +0530 |
|---|---|---|
| committer | Pranith Kumar Karampuri <pkarampu@redhat.com> | 2016-11-23 21:44:51 -0800 |
| commit | 66f5c8a6f06c389cfb8b845254d3033f2b22801a (patch) | |
| tree | 4b04ef958d765aa0c0692ecd30ff49c32740fbf7 /cli | |
| parent | 73b0debb4f489f671e3fcd33b2c70ca9f3a2b70a (diff) | |
events: Add FMT_WARN for gf_event
Raghavendra G found that posix is trying to print %s
but passing an int when HEALTH_CHECK fails in posix.
These are the kind of bugs that should be caught
at compilation itself.
Also fixed the problematic gf_event() callers.
>BUG: 1386097
>Change-Id: Id7bd6d9a9690237cec3ca1aefa2aac085e8a1270
>Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
>Reviewed-on: http://review.gluster.org/15671
>Smoke: Gluster Build System <jenkins@build.gluster.org>
>NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
>Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
>CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
BUG: 1396778
Change-Id: Idf8e1f427578d02dccd2a8165884a5cf086eb07e
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15884
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Diffstat (limited to 'cli')
| -rw-r--r-- | cli/src/cli-cmd-volume.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/cli/src/cli-cmd-volume.c b/cli/src/cli-cmd-volume.c index 0c9400ffc29..cfc1af02643 100644 --- a/cli/src/cli-cmd-volume.c +++ b/cli/src/cli-cmd-volume.c @@ -1061,7 +1061,7 @@ out: cli_out ("Volume add-brick failed"); } else { #if (USE_EVENTS) - gf_event (EVENT_VOLUME_ADD_BRICK, event_str); + gf_event (EVENT_VOLUME_ADD_BRICK, "%s", event_str); GF_FREE (event_str); #endif } @@ -2050,7 +2050,7 @@ out: } else { #if (USE_EVENTS) if (!event_ret) { - gf_event (event, event_str); + gf_event (event, "%s", event_str); GF_FREE (event_str); } #endif |