summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSoumya Koduri <skoduri@redhat.com>2018-12-26 15:24:49 +0530
committerKaleb KEITHLEY <kkeithle@redhat.com>2018-12-31 16:10:04 +0000
commitd9a8ccd354df6db94477bf9ecb09735194523665 (patch)
tree92134b8b50a15ab9081918121afb05a898b3343b
parent1ea203d6b6960621c6b445db42d6254c726df321 (diff)
gfapi: nit cleanup related to releasing fs->mutex lock
This is follow-up patch to the comment received for - https://review.gluster.org/#/c/glusterfs/+/21882 We need not hold the fs->mutex lock to log error message. Change-Id: I29d2ea2e6cfecc3dd94982bd48f4bc9f11cc3aac fixes: bz#1660577 Signed-off-by: Soumya Koduri <skoduri@redhat.com>
-rw-r--r--api/src/glfs-mgmt.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/api/src/glfs-mgmt.c b/api/src/glfs-mgmt.c
index 7ef5ec93af1..e8ad020c752 100644
--- a/api/src/glfs-mgmt.c
+++ b/api/src/glfs-mgmt.c
@@ -656,9 +656,9 @@ volfile:
pthread_mutex_lock(&fs->mutex);
if ((size == fs->oldvollen) &&
(memcmp(fs->oldvolfile, rsp.spec, size) == 0)) {
+ pthread_mutex_unlock(&fs->mutex);
gf_msg(frame->this->name, GF_LOG_INFO, 0, API_MSG_VOLFILE_INFO,
"No change in volfile, continuing");
- pthread_mutex_unlock(&fs->mutex);
goto out;
}
pthread_mutex_unlock(&fs->mutex);