summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSanju Rakonde <srakonde@redhat.com>2018-12-27 14:54:28 +0530
committerSanju Rakonde <srakonde@redhat.com>2018-12-27 18:15:13 +0530
commita6dc153e47f9025b09e8aae14ca6ba96fa20a23e (patch)
tree45079a06ecd2b907634cb229d09ad36f123c8c9e
parentb5a8a91c1d86f30cb669ca469b83c99b2e9dafcb (diff)
glusterd: coverity fixes
This patch addresses coverity issues with CID 1398470 and 1398475 1398470 - Missing unlock - False positive, Added a annotation to make coverity happy 1398475 - Unused value Change-Id: I1bb3df0b716690fad8fc52c393c8b2b6c41f7860 updates: bz#789278 Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-sm.c1
-rw-r--r--xlators/mgmt/glusterd/src/glusterd.c2
2 files changed, 3 insertions, 0 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-sm.c b/xlators/mgmt/glusterd/src/glusterd-sm.c
index 2d2e5c852eb..73a11a3eace 100644
--- a/xlators/mgmt/glusterd/src/glusterd-sm.c
+++ b/xlators/mgmt/glusterd/src/glusterd-sm.c
@@ -868,6 +868,7 @@ glusterd_ac_friend_remove(glusterd_friend_sm_event_t *event, void *ctx)
"Cleanup returned: %d", ret);
}
out:
+ /* coverity[ LOCK] */
return 0;
}
diff --git a/xlators/mgmt/glusterd/src/glusterd.c b/xlators/mgmt/glusterd/src/glusterd.c
index 45f387a0be1..ff5af42079d 100644
--- a/xlators/mgmt/glusterd/src/glusterd.c
+++ b/xlators/mgmt/glusterd/src/glusterd.c
@@ -1999,6 +1999,8 @@ init(xlator_t *this)
op_version, GD_OP_VERSION_MAX);
glusterd_recreate_volfiles(conf);
ret = glusterd_store_max_op_version(this);
+ if (ret)
+ gf_log(this->name, GF_LOG_ERROR, "Failed to store max op-version");
}
/* If the peer count is less than 2 then this would be the best time to