summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAmar Tumballi <amarts@redhat.com>2019-01-16 20:24:06 +0530
committerShyamsundar Ranganathan <srangana@redhat.com>2019-01-23 16:05:52 +0000
commit990d6a99d41111ea18481db55566a96c2fc4dad4 (patch)
treebec393dd7389a12d072cf6f5e172c821e60014b2
parentcf12a446f86169d0954e68dad36a7763cb178a0e (diff)
core: move logs which are only developer relevant to DEBUG level
We had only changed the log level to DEBUG in release branch earlier. But considering 90%+ of our deployments happen in same env, we can look at these specific logs on need basis. With this change, the master branch will be easier to debug with lesser logs. Change-Id: I4157a7ec7d5ec9c2948b2bbc1e4cb8317f28d6b8 Updates: bz#1666833 Signed-off-by: Amar Tumballi <amarts@redhat.com>
-rw-r--r--libglusterfs/src/dict.c6
-rw-r--r--libglusterfs/src/graph.c2
-rw-r--r--libglusterfs/src/options.c2
-rw-r--r--rpc/xdr/src/glusterfs3.h2
4 files changed, 6 insertions, 6 deletions
diff --git a/libglusterfs/src/dict.c b/libglusterfs/src/dict.c
index 83647b0174a..4f4ae3de64c 100644
--- a/libglusterfs/src/dict.c
+++ b/libglusterfs/src/dict.c
@@ -39,14 +39,14 @@ struct dict_cmp {
#define VALIDATE_DATA_AND_LOG(data, type, key, ret_val) \
do { \
if (!data || !data->data) { \
- gf_msg_callingfn("dict", GF_LOG_WARNING, EINVAL, \
- LG_MSG_INVALID_ARG, "data is NULL"); \
+ gf_msg_callingfn("dict", GF_LOG_DEBUG, EINVAL, LG_MSG_INVALID_ARG, \
+ "data is NULL"); \
return ret_val; \
} \
/* Not of the asked type, or old version */ \
if ((data->data_type != type) && \
(data->data_type != GF_DATA_TYPE_STR_OLD)) { \
- gf_msg_callingfn("dict", GF_LOG_INFO, EINVAL, LG_MSG_INVALID_ARG, \
+ gf_msg_callingfn("dict", GF_LOG_DEBUG, EINVAL, LG_MSG_INVALID_ARG, \
"key %s, %s type asked, has %s type", key, \
data_type_name[type], \
data_type_name[data->data_type]); \
diff --git a/libglusterfs/src/graph.c b/libglusterfs/src/graph.c
index 2dad92a5c53..bb5e67a5e60 100644
--- a/libglusterfs/src/graph.c
+++ b/libglusterfs/src/graph.c
@@ -393,7 +393,7 @@ _log_if_unknown_option(dict_t *dict, char *key, data_t *value, void *data)
found = xlator_volume_option_get(xl, key);
if (!found) {
- gf_msg(xl->name, GF_LOG_WARNING, 0, LG_MSG_XLATOR_OPTION_INVALID,
+ gf_msg(xl->name, GF_LOG_DEBUG, 0, LG_MSG_XLATOR_OPTION_INVALID,
"option '%s' is not recognized", key);
}
diff --git a/libglusterfs/src/options.c b/libglusterfs/src/options.c
index da24122205e..2884d200caa 100644
--- a/libglusterfs/src/options.c
+++ b/libglusterfs/src/options.c
@@ -966,7 +966,7 @@ xl_opt_validate(dict_t *dict, char *key, data_t *value, void *data)
stub->errstr = errstr;
if (fnmatch(opt->key[0], key, FNM_NOESCAPE) != 0) {
- gf_msg(xl->name, GF_LOG_WARNING, 0, LG_MSG_INVALID_ENTRY,
+ gf_msg(xl->name, GF_LOG_DEBUG, 0, LG_MSG_INVALID_ENTRY,
"option '%s' is deprecated, preferred is '%s', "
"continuing with correction",
key, opt->key[0]);
diff --git a/rpc/xdr/src/glusterfs3.h b/rpc/xdr/src/glusterfs3.h
index 6e5de623457..0de7cb8abf5 100644
--- a/rpc/xdr/src/glusterfs3.h
+++ b/rpc/xdr/src/glusterfs3.h
@@ -741,7 +741,7 @@ dict_to_xdr(dict_t *this, gfx_dict *dict)
xpair->value.gfx_value_u.other.other_len = dpair->value->len;
/* Change this to INFO, after taking the above down */
- gf_msg("dict", GF_LOG_INFO, EINVAL, LG_MSG_DICT_SERIAL_FAILED,
+ gf_msg("dict", GF_LOG_DEBUG, EINVAL, LG_MSG_DICT_SERIAL_FAILED,
"key '%s' would not be sent on wire in the future",
dpair->key);
break;