diff options
| author | Saravanakumar Arumugam <sarumuga@redhat.com> | 2015-02-25 11:43:14 +0530 |
|---|---|---|
| committer | Vijay Bellur <vbellur@redhat.com> | 2015-04-16 18:24:45 +0000 |
| commit | 56a04936f29a21b7bd277b4b9dc92fea01730c2e (patch) | |
| tree | abbe7f113c6186b429a0e1ac02970555adb70e9c | |
| parent | 2ab703d12020178f8520674e9903f2e74a650bbd (diff) | |
glusterd/snapshot: Fix memory leak while using scandir
scandir allocates memory for dirent entries.
Ensure to free them up once they are used.
Noticed this while looking for a sample scandir implementation.
Change-Id: Iff5f76e93e698d3f454f273d9dd7d9a15cf63953
BUG: 1196027
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/9739
Reviewed-by: Sachin Pandit <spandit@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-snapshot.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-snapshot.c b/xlators/mgmt/glusterd/src/glusterd-snapshot.c index cdd19cd354d..476bfb8e017 100644 --- a/xlators/mgmt/glusterd/src/glusterd-snapshot.c +++ b/xlators/mgmt/glusterd/src/glusterd-snapshot.c @@ -551,6 +551,14 @@ glusterd_copy_geo_rep_session_files (char *session, } } out: + /* files are malloc'd by scandir, free them */ + if (file_count > 0) { + while (file_count--) { + free(files[file_count]); + } + free(files); + } + if (reg_exp) GF_FREE (reg_exp); |