diff options
| author | Pranith Kumar K <pkarampu@redhat.com> | 2016-08-02 15:19:00 +0530 |
|---|---|---|
| committer | Pranith Kumar Karampuri <pkarampu@redhat.com> | 2016-08-23 08:08:42 -0700 |
| commit | 036c4fcab82d4e69bf3e53d93f7da9b0b1dd900c (patch) | |
| tree | afeee41a1ea769efd85b287e505ad4ffcf114241 | |
| parent | 72af868ba4a0ff7e143adaec78168aaccda473ef (diff) | |
cluster/afr: copy loc before passing to syncop
Problem:
When io-threads is enabled on the client side, io-threads destroys the
call-stub in which the loc is stored as soon as the c-stack unwinds.
Because afr is creating a syncop with the address of loc passed in
setxattr by the time syncop tries to access it, io-threads would have
already freed the call-stub. This will lead to crash.
Fix:
Copy loc to frame->local and use it's address.
> Reviewed-on: http://review.gluster.org/15070
> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
> Smoke: Gluster Build System <jenkins@build.gluster.org>
> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
> Reviewed-by: Ravishankar N <ravishankar@redhat.com>
BUG: 1369042
Change-Id: I16987e491e24b0b4e3d868a6968e802e47c77f7a
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Reviewed-on: http://review.gluster.org/15233
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
| -rw-r--r-- | xlators/cluster/afr/src/afr-inode-write.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/xlators/cluster/afr/src/afr-inode-write.c b/xlators/cluster/afr/src/afr-inode-write.c index fa29a5e9291..ddc257dbde4 100644 --- a/xlators/cluster/afr/src/afr-inode-write.c +++ b/xlators/cluster/afr/src/afr-inode-write.c @@ -1412,7 +1412,8 @@ afr_handle_split_brain_commands (xlator_t *this, call_frame_t *frame, } data->spb_child_index = spb_child_index; data->frame = frame; - data->loc = loc; + loc_copy (&local->loc, loc); + data->loc = &local->loc; ret = synctask_new (this->ctx->env, afr_can_set_split_brain_choice, afr_set_split_brain_choice, NULL, data); |