diff options
| author | jiffin tony thottan <jthottan@redhat.com> | 2015-11-16 15:51:01 +0530 |
|---|---|---|
| committer | Raghavendra G <rgowdapp@redhat.com> | 2016-02-02 21:20:04 -0800 |
| commit | 8d4c9532086222bfbb7a6d48f9f9c01e58b4dcf3 (patch) | |
| tree | 4efa51f7c931176a218ce67cfeaef9cd5f8f685b | |
| parent | 4ae9ac6dd48d378984fa3a34a6b63d90bc74e431 (diff) | |
marker : handle variable `ret` properly in marker_unlink_cbk
Backport of http://review.gluster.org/#/c/12584/
While compiling new source, the following issue got hit :
marker.c: In function 'marker_unlink_cbk':
marker.c:994:29: warning: variable 'ret' set but not used
int32_t ret = 0;
This patch will fix the same.
Upstream reference :
cherry picked from commit eada31c88f929768df5fa337137b2ffcd57f2e73
>Change-Id: I0de60bed3351b3aa1cc80f52d178e447826210e7
>BUG: 1257694
>Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
>Reviewed-on: http://review.gluster.org/12584
>Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
>Tested-by: NetBSD Build System <jenkins@build.gluster.org>
>Tested-by: Gluster Build System <jenkins@build.gluster.com>
>Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Change-Id: Ia8f87131e90599cad018cd31269de68049a2ade9
BUG: 1279331
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: http://review.gluster.org/12596
Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
| -rw-r--r-- | xlators/features/marker/src/marker.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/xlators/features/marker/src/marker.c b/xlators/features/marker/src/marker.c index 0a9d3a74560..3aae155e85a 100644 --- a/xlators/features/marker/src/marker.c +++ b/xlators/features/marker/src/marker.c @@ -1014,10 +1014,15 @@ marker_unlink_cbk (call_frame_t *frame, void *cookie, xlator_t *this, if (priv->feature_enabled & GF_QUOTA) { if (!local->skip_txn) { - if (xdata) + if (xdata) { ret = dict_get_uint32 (xdata, GF_RESPONSE_LINK_COUNT_XDATA, &nlink); - + if (ret) { + gf_log (this->name, GF_LOG_TRACE, + "dict get failed %s ", + strerror (-ret)); + } + } mq_reduce_parent_size_txn (this, &local->loc, NULL, nlink); } |