summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRaghavendra G <raghavendra@gluster.com>2011-11-03 14:59:53 +0530
committerAnand Avati <avati@gluster.com>2011-11-03 06:18:03 -0700
commitbd42aec6c907c14f7c86d7fd6f60b8d78d411fb1 (patch)
treed6172f516fd3a8b8c35724bcb77873abc36e8404
parent208244f0126886a60ae7b2a2e8126a7bab6040cb (diff)
performance/write-behind: queue setattr fop with writes always.
stat returned in setattr_cbk can be cached by the kernel. Hence it is always necessary that we return correct stat, which implies that setattr should not be out of order with respect to write fops. Change-Id: Iaac1c79545760ac77ba3eae1ac2fee9f4e446fb9 BUG: 3711 Reviewed-on: http://review.gluster.com/665 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
-rw-r--r--xlators/performance/write-behind/src/write-behind.c9
1 files changed, 1 insertions, 8 deletions
diff --git a/xlators/performance/write-behind/src/write-behind.c b/xlators/performance/write-behind/src/write-behind.c
index 1a8bfe7df58..2124550de4b 100644
--- a/xlators/performance/write-behind/src/write-behind.c
+++ b/xlators/performance/write-behind/src/write-behind.c
@@ -1277,13 +1277,6 @@ wb_setattr (call_frame_t *frame, xlator_t *this, loc_t *loc,
frame->local = local;
- if (!(valid & (GF_SET_ATTR_ATIME | GF_SET_ATTR_MTIME))) {
- STACK_WIND (frame, wb_setattr_cbk, FIRST_CHILD (this),
- FIRST_CHILD (this)->fops->setattr, loc, stbuf,
- valid);
- goto out;
- }
-
if (loc->inode) {
/*
FIXME: fd_lookup extends life of fd till the execution
@@ -1334,7 +1327,7 @@ unwind:
if (stub) {
call_stub_destroy (stub);
}
-out:
+
return 0;
}