diff options
| author | Vijay Bellur <vijay@gluster.com> | 2010-01-23 12:53:56 +0000 | 
|---|---|---|
| committer | Anand V. Avati <avati@dev.gluster.com> | 2010-01-23 10:37:17 -0800 | 
| commit | 6313f854fb41ef0a61a40b08a4cf05254763eb21 (patch) | |
| tree | 8a3d0d9ba901b7d81049aa49f93edebbcf060084 | |
| parent | 502fef89bb352aa8092c3b2e606757c5ef644171 (diff) | |
protocol/client: Look only for op_ret while handling a setvolume response.
op_errno should not be looked up to stop processing setvolume_cbk().
This fixes the problem of 3.0.x clients crashing if they attempt to
connect to 2.0.x servers.
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 564 (3.0.1rc3 server daemon crashes when any of the 2.0.x version client connects)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=564
| -rw-r--r-- | xlators/protocol/client/src/client-protocol.c | 2 | 
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/protocol/client/src/client-protocol.c b/xlators/protocol/client/src/client-protocol.c index 27c4d2dd83f..64c3456a109 100644 --- a/xlators/protocol/client/src/client-protocol.c +++ b/xlators/protocol/client/src/client-protocol.c @@ -6151,7 +6151,7 @@ client_setvolume_cbk (call_frame_t *frame, gf_hdr_common_t *hdr, size_t hdrlen,          op_ret   = ntoh32 (hdr->rsp.op_ret);          op_errno = gf_error_to_errno (ntoh32 (hdr->rsp.op_errno)); -        if ((op_ret < 0) && (op_errno == ENOTCONN)) { +        if (op_ret < 0) {                  gf_log (this->name, GF_LOG_DEBUG,                          "setvolume failed (%s)",                          strerror (op_errno));  | 
