summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNandaja Varma <nandaja.varma@gmail.com>2015-02-18 16:40:03 +0530
committerVijay Bellur <vbellur@redhat.com>2015-03-24 11:24:29 -0700
commitd71418ac4e2da989fc49eece4e2acbb9288b71f9 (patch)
treeadd5a1770101879053c193241e24a3db431499a1
parentcd3d34289c92f01843a866f4432bdd2da1ee59db (diff)
glusterd: Fixing wrong array comparison (Coverity fix)
Coverity CID: 1256175 Change-Id: Ib29fc2eaa54a7ce8369918e68bf117d0f04ca94d BUG: 789278 Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com> Reviewed-on: http://review.gluster.org/9679 Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com> Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com> Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com> Reviewed-by: Vijay Bellur <vbellur@redhat.com>
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-snapshot.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-snapshot.c b/xlators/mgmt/glusterd/src/glusterd-snapshot.c
index 761115d22ed..7359040f18c 100644
--- a/xlators/mgmt/glusterd/src/glusterd-snapshot.c
+++ b/xlators/mgmt/glusterd/src/glusterd-snapshot.c
@@ -2597,7 +2597,7 @@ glusterd_lvm_snapshot_remove (dict_t *rsp_dict, glusterd_volinfo_t *snap_vol)
}
/* Check if the brick has a LV associated with it */
- if (!brickinfo->device_path) {
+ if (strlen(brickinfo->device_path) == 0) {
gf_log (this->name, GF_LOG_DEBUG,
"Brick (%s:%s) does not have a LV "
"associated with it. Removing the brick path",