summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSanju Rakonde <srakonde@redhat.com>2017-10-18 08:06:24 +0530
committerAtin Mukherjee <amukherj@redhat.com>2017-10-20 02:31:47 +0000
commit87bd25b64ae34cce95e87e724acfeab4c13d60a4 (patch)
tree1d7345f547e69896f786b4520276a632db2fcd42
parent087703fae449b725ebd82bc3cd65763a016fb098 (diff)
glusterfsd: Dereferencing the null pointer
Problem: When control reaches to out, one of (iobref, iobuf, frame) can be null.for iobref, iobuf iobref_unref() and iobuf_unref() functions are called respectively, which are using GF_VALIDATE_OR_GOTO(), so there won't be null pointer dereference. But for frame without null checking STACK_DESTROY(frame->root) is called causing null pointer dereference. Fix: adding a line for null checking, the function STACK_DESTROY(frame->root) is called only when frame is not null. Change-Id: I3a6684c11fb7b694b81d6ad4fec3bced5562ad88 BUG: 1503394 Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
-rw-r--r--glusterfsd/src/gf_attach.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/glusterfsd/src/gf_attach.c b/glusterfsd/src/gf_attach.c
index 05119e4..3f24829 100644
--- a/glusterfsd/src/gf_attach.c
+++ b/glusterfsd/src/gf_attach.c
@@ -144,7 +144,8 @@ out:
iobref_unref (iobref);
iobuf_unref (iobuf);
- STACK_DESTROY (frame->root);
+ if (frame)
+ STACK_DESTROY (frame->root);
if (rpc_status != 0) {
fprintf (stderr, "got error %d on RPC\n", rpc_status);