diff options
| author | Shehjar Tikoo <shehjart@gluster.com> | 2011-03-29 03:50:19 +0000 |
|---|---|---|
| committer | Vijay Bellur <vijay@dev.gluster.com> | 2011-03-30 03:24:38 -0700 |
| commit | 4954170c7ee17105ab28ef13ca365a3dbe23fdb3 (patch) | |
| tree | 35c4c85517541dc7d1d70ca941e9b00c2f04b39f | |
| parent | 229b6136c26b740091a32aa972e2224695ee837b (diff) | |
nfs: Remove redundant and erroneous check for create mode EXCLUSIVE
nfs3.c/nfs3_create_common:
The if condition checks for create mode being EXCLUSIVE. However, when
create mode is EXCLUSIVE, this function never gets called (nfs3_create_exclusive
is called). Also, instead of checking, it actually sets the value of createmode (= instead of ==).
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2553 (NFS file create with Mac client and UNCHECKED mode returns "Operation not permitted")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2553
| -rw-r--r-- | xlators/nfs/server/src/nfs3.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/nfs/server/src/nfs3.c b/xlators/nfs/server/src/nfs3.c index 5f8f8ee938f..0f2c284ecaf 100644 --- a/xlators/nfs/server/src/nfs3.c +++ b/xlators/nfs/server/src/nfs3.c @@ -2361,7 +2361,7 @@ nfs3_create_common (nfs3_call_state_t *cs) if (!cs) return ret; - if ((cs->createmode == UNCHECKED) || (cs->createmode = EXCLUSIVE)) + if (cs->createmode == UNCHECKED) flags = O_RDWR; else if (cs->createmode == GUARDED) flags = (O_RDWR | O_EXCL); |