diff options
| author | Pranith Kumar K <pkarampu@redhat.com> | 2015-01-14 17:10:41 +0530 | 
|---|---|---|
| committer | Raghavendra Bhat <raghavendra@redhat.com> | 2015-02-11 01:49:16 -0800 | 
| commit | 098d823dd771115be5ebbdc4e14ae68451da7f6a (patch) | |
| tree | 035b59a9cf374bd9038facc77152b802c47284d3 | |
| parent | d9125608b33181fed8052ff5f867b2cb5c4e679f (diff) | |
storage/posix: Don't try to set gfid in case of INTERNAL-mknod
        Backport of http://review.gluster.org/9446
BUG: 1184527
Change-Id: I3e31b0672704cae09c5097f84229b8264a6c0fbe
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/9472
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
| -rw-r--r-- | xlators/storage/posix/src/posix.c | 19 | 
1 files changed, 12 insertions, 7 deletions
diff --git a/xlators/storage/posix/src/posix.c b/xlators/storage/posix/src/posix.c index f52fff303fa..f39fbd433bc 100644 --- a/xlators/storage/posix/src/posix.c +++ b/xlators/storage/posix/src/posix.c @@ -1067,6 +1067,7 @@ posix_mknod (call_frame_t *frame, xlator_t *this,          int32_t               nlink_samepgfid = 0;          char                 *pgfid_xattr_key = NULL;          gf_boolean_t          entry_created   = _gf_false, gfid_set = _gf_false; +        gf_boolean_t          linked          = _gf_false;          DECLARE_OLD_FS_ID_VAR; @@ -1110,8 +1111,10 @@ posix_mknod (call_frame_t *frame, xlator_t *this,                  }                  op_ret = posix_create_link_if_gfid_exists (this, uuid_req,                                                             real_path); -                if (!op_ret) +                if (!op_ret) { +                        linked = _gf_true;                          goto post_op; +                }          }  real_op: @@ -1182,12 +1185,14 @@ ignore:                          strerror (errno));          } -        op_ret = posix_gfid_set (this, real_path, loc, xdata); -        if (op_ret) { -                gf_log (this->name, GF_LOG_ERROR, -                        "setting gfid on %s failed", real_path); -        } else { -                gfid_set = _gf_true; +        if (!linked) { +                op_ret = posix_gfid_set (this, real_path, loc, xdata); +                if (op_ret) { +                        gf_log (this->name, GF_LOG_ERROR, +                                "setting gfid on %s failed", real_path); +                } else { +                        gfid_set = _gf_true; +                }          }          op_ret = posix_pstat (this, NULL, real_path, &stbuf);  | 
