summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYaniv Kaul <ykaul@redhat.com>2019-03-20 13:05:44 +0200
committerAtin Mukherjee <amukherj@redhat.com>2019-03-21 04:38:35 +0000
commit8aff9cc5c6277ef7dacfb89f1392b7c2eda9b825 (patch)
tree023923d4c6643968a8aa8f95602b65e51de89286
parentf2f07591b2de9ba45bbc3eb4f601d1e9a327190b (diff)
server.c: fix Coverity CID 1399758
1399758 Dereference before null check It was introduced @ commit 67f48bfcc16a38052e6c9ae7c25e69b03b8ae008 updates: bz#789278 Signed-off-by: Yaniv Kaul <ykaul@redhat.com> Change-Id: I1424b008b240691fe2a8924e31c708d0fb4f362d
-rw-r--r--xlators/protocol/server/src/server.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/xlators/protocol/server/src/server.c b/xlators/protocol/server/src/server.c
index 9cfc556..45a5e96 100644
--- a/xlators/protocol/server/src/server.c
+++ b/xlators/protocol/server/src/server.c
@@ -440,7 +440,6 @@ server_rpc_notify(rpcsvc_t *rpc, void *xl, rpcsvc_event_t event, void *data)
this = xl;
trans = data;
- conf = this->private;
if (!this || !data || !this->ctx || !this->ctx->active) {
gf_msg_callingfn("server", GF_LOG_WARNING, 0, PS_MSG_RPC_NOTIFY_ERROR,
@@ -448,6 +447,8 @@ server_rpc_notify(rpcsvc_t *rpc, void *xl, rpcsvc_event_t event, void *data)
goto out;
}
+ conf = this->private;
+
switch (event) {
case RPCSVC_EVENT_ACCEPT: {
/* Have a structure per new connection */