summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKaleb S. KEITHLEY <kkeithle@redhat.com>2015-06-03 09:59:30 -0400
committerVijay Bellur <vbellur@redhat.com>2015-11-01 06:43:04 -0800
commit846697d91ed56ca3d76f2a78e87e7675f127f21d (patch)
tree7d3544ee60e019c7558b0e1a473454eb77c0106d
parentd29dd0747dbb2e7383867c97cbbaa8c41851db78 (diff)
core: fix Ubuntu code audit (cppcheck) results
This change includes an additional fix (forward port) of a fix made on the release-3.x branches to address a comment made after the original change was merged on the master branch. * release-3.7 * Change-Id: Ie15c5919e5bf9b0a1c66e20dc42d80fdfa8bd7f4 * BZ: 1227808 * http://review.gluster.org/11069 Change-Id: I4fc2672ab1a17998b2e40bc43eb6a3e15058a086 BUG: 1109180 Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com> Reviewed-on: http://review.gluster.org/11067 Tested-by: NetBSD Build System <jenkins@build.gluster.org> Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vbellur@redhat.com>
-rw-r--r--xlators/performance/quick-read/src/quick-read.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/performance/quick-read/src/quick-read.c b/xlators/performance/quick-read/src/quick-read.c
index 58fde4b4e81..4e9c6dcf091 100644
--- a/xlators/performance/quick-read/src/quick-read.c
+++ b/xlators/performance/quick-read/src/quick-read.c
@@ -614,7 +614,7 @@ qr_readv (call_frame_t *frame, xlator_t *this, fd_t *fd, size_t size,
if (!qr_inode)
goto wind;
- if (qr_readv_cached (frame, qr_inode, size, offset, flags, xdata) <= 0)
+ if (qr_readv_cached (frame, qr_inode, size, offset, flags, xdata) < 0)
goto wind;
return 0;