summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPranith Kumar K <pkarampu@redhat.com>2016-08-02 15:19:00 +0530
committerPranith Kumar Karampuri <pkarampu@redhat.com>2016-08-04 01:47:09 -0700
commit67ebde53ea26065d41cacf054fa4337c22de5903 (patch)
tree51e00779f144a37cdd96e93d8fd5865f5c29e141
parentc3dee6d35326c6495591eb5bbf7f52f64031e2c4 (diff)
cluster/afr: copy loc before passing to syncop
Problem: When io-threads is enabled on the client side, io-threads destroys the call-stub in which the loc is stored as soon as the c-stack unwinds. Because afr is creating a syncop with the address of loc passed in setxattr by the time syncop tries to access it, io-threads would have already freed the call-stub. This will lead to crash. Fix: Copy loc to frame->local and use it's address. BUG: 1361678 Change-Id: I16987e491e24b0b4e3d868a6968e802e47c77f7a Signed-off-by: Pranith Kumar K <pkarampu@redhat.com> Reviewed-on: http://review.gluster.org/15070 Reviewed-by: Ravishankar N <ravishankar@redhat.com> Smoke: Gluster Build System <jenkins@build.gluster.org> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
-rw-r--r--xlators/cluster/afr/src/afr-inode-write.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/xlators/cluster/afr/src/afr-inode-write.c b/xlators/cluster/afr/src/afr-inode-write.c
index 76526bcf177..323f50c9413 100644
--- a/xlators/cluster/afr/src/afr-inode-write.c
+++ b/xlators/cluster/afr/src/afr-inode-write.c
@@ -1413,7 +1413,8 @@ afr_handle_split_brain_commands (xlator_t *this, call_frame_t *frame,
}
data->spb_child_index = spb_child_index;
data->frame = frame;
- data->loc = loc;
+ loc_copy (&local->loc, loc);
+ data->loc = &local->loc;
ret = synctask_new (this->ctx->env,
afr_can_set_split_brain_choice,
afr_set_split_brain_choice, NULL, data);