diff options
| author | Sven Fischer <sven@fischer-abc.de> | 2018-03-17 23:30:38 +0100 |
|---|---|---|
| committer | Raghavendra G <rgowdapp@redhat.com> | 2018-03-19 03:30:31 +0000 |
| commit | de52876407040a8cae9656ede9f66084d4cb45ac (patch) | |
| tree | 1e5a2fc4a4b2a16bf765c144e4aad4d58b07bc36 | |
| parent | 97233b3f69595a7d7a3da3a80a6911b8b4985881 (diff) | |
cleanup: xlator_t structure's 'client_latency' variable is not used
- Removed unused struct member and its one time usage.
- cleaned up wrong white space
member 'client_latency' was not used otherwise since it was added by
commit 07cc8679cdf3b29680f4f105d0222da168d8bfc1
Author: Kevin Vigor <kvigor@fb.com>
Date: Tue Mar 21 08:23:25 2017 -0700
Halo Replication feature for AFR translator
Change-Id: Ibb0ea828d4090bbe8897f6af326b317884162a00
BUG: 1495153
Signed-off-by: Sven Fischer <sven@fischer-abc.de>
| -rw-r--r-- | libglusterfs/src/xlator.h | 15 | ||||
| -rw-r--r-- | rpc/rpc-lib/src/rpc-clnt-ping.c | 2 |
2 files changed, 7 insertions, 10 deletions
diff --git a/libglusterfs/src/xlator.h b/libglusterfs/src/xlator.h index b03998d36af..be6cf60e8c7 100644 --- a/libglusterfs/src/xlator.h +++ b/libglusterfs/src/xlator.h @@ -978,18 +978,17 @@ struct _xlator { struct xlator_dumpops *dumpops; struct list_head volume_options; /* list of volume_option_t */ - void (*fini) (xlator_t *this); - int32_t (*init) (xlator_t *this); - int32_t (*reconfigure) (xlator_t *this, dict_t *options); - int32_t (*mem_acct_init) (xlator_t *this); - int32_t (*dump_metrics) (xlator_t *this, int fd); + void (*fini)(xlator_t *this); + int32_t (*init)(xlator_t *this); + int32_t (*reconfigure)(xlator_t *this, dict_t *options); + int32_t (*mem_acct_init)(xlator_t *this); + int32_t (*dump_metrics)(xlator_t *this, int fd); - event_notify_fn_t notify; + event_notify_fn_t notify; - gf_loglevel_t loglevel; /* Log level for translator */ + gf_loglevel_t loglevel; /* Log level for translator */ struct { - int64_t client_latency; /* This is in 'milliseconds' units */ struct { /* for latency measurement */ fop_metrics_t metrics[GF_FOP_MAXVALUE]; diff --git a/rpc/rpc-lib/src/rpc-clnt-ping.c b/rpc/rpc-lib/src/rpc-clnt-ping.c index 40077e7aefd..af4a993476e 100644 --- a/rpc/rpc-lib/src/rpc-clnt-ping.c +++ b/rpc/rpc-lib/src/rpc-clnt-ping.c @@ -205,8 +205,6 @@ rpc_clnt_ping_cbk (struct rpc_req *req, struct iovec *iov, int count, pthread_mutex_lock (&conn->lock); { - /* TODO: concerned people, check why this is used nowhere? */ - this->stats.client_latency = latency_msec; gf_log (THIS->name, GF_LOG_DEBUG, "Ping latency is %" PRIu64 "ms", latency_msec); |