diff options
| author | Sanju Rakonde <srakonde@redhat.com> | 2017-09-25 12:34:05 +0530 | 
|---|---|---|
| committer | Jeff Darcy <jeff@pl.atyp.us> | 2017-09-26 13:06:33 +0000 | 
| commit | b269089a33bd1348d34c861817c3f673206b6a18 (patch) | |
| tree | 8a37e22c9fe5249ad6f66a318c890211621a259c | |
| parent | 83d2bf8815bb4d79349659a7d5b9df822acd5430 (diff) | |
Glusterfsd: Unreachable statements
Issue: Event unreachable at line number 1111 in glusterfsd/src/glusterfsd.c
There was a statement in outer if block after the break statement.
Ideally the break statement should be inside the inner if block so
that the statement will not become unreachable. I put the break
inside the inner if block.
Change-Id: Id4917305333e1638f35b3f2fb59ac42e62a12d02
BUG: 789278
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
| -rw-r--r-- | glusterfsd/src/glusterfsd.c | 6 | 
1 files changed, 3 insertions, 3 deletions
diff --git a/glusterfsd/src/glusterfsd.c b/glusterfsd/src/glusterfsd.c index 76e57d9c165..fc902ed0484 100644 --- a/glusterfsd/src/glusterfsd.c +++ b/glusterfsd/src/glusterfsd.c @@ -1115,10 +1115,10 @@ parse_opts (int key, char *arg, struct argp_state *state)                          cmd_args->brick_port = n;                          port_str = strtok_r (NULL, ",", &tmp_str);                          if (port_str) { -                                if (gf_string2uint_base10 (port_str, &n) == 0) +                                if (gf_string2uint_base10 (port_str, &n) == 0) {                                          cmd_args->brick_port2 = n; -                                break; - +                                        break; +                                }                                  argp_failure (state, -1, 0,                                                "wrong brick (listen) port %s", arg);                          }  | 
