summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHuangShujun <549702281@qq.com>2019-12-05 10:07:10 +0200
committerhari gowtham <hari.gowtham005@gmail.com>2020-02-11 08:27:55 +0000
commit9bde9ac78f31214a8c4b18bccc54abd9a809cdc9 (patch)
tree951cb2d570d466e87f8edc2ab71c97ee30b821ec
parentb41f24c341cd508e5137618ffbba6a600c497f38 (diff)
To fix readdir-ahead memory leak
Glusterfs client process has memory leak if create serveral files under one folder, and delete the folder. According to statedump, the ref counts of readdir-ahead is bigger than zero in the inode table. Readdir-ahead get parent inode by inode_parent in rda_mark_inode_dirty when each rda_writev_cbk,the inode ref count of parent folder will be increased in inode_parent, but readdir-ahead do not unref it later. The correction is unref the parent inode at the end of rda_mark_inode_dirty Backport of: > Change-Id: Iee68ab1089cbc2fbc4185b93720fb1f66ee89524 > Fixes: bz#1779055 > Signed-off-by: HuangShujun <549702281@qq.com> Change-Id: Iee68ab1089cbc2fbc4185b93720fb1f66ee89524 (cherry picked from commit 99044a5cedcff9a9eec40a07ecb32bd66271cd02) Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com> Fixes: bz#1789337
-rw-r--r--xlators/performance/readdir-ahead/src/readdir-ahead.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/xlators/performance/readdir-ahead/src/readdir-ahead.c b/xlators/performance/readdir-ahead/src/readdir-ahead.c
index 7fd4f8d..933941d 100644
--- a/xlators/performance/readdir-ahead/src/readdir-ahead.c
+++ b/xlators/performance/readdir-ahead/src/readdir-ahead.c
@@ -254,6 +254,7 @@ rda_mark_inode_dirty(xlator_t *this, inode_t *inode)
}
}
UNLOCK(&parent->lock);
+ inode_unref(parent);
}
return;