diff options
| author | Mohit Agrawal <moagrawa@redhat.com> | 2016-10-26 18:41:42 +0530 |
|---|---|---|
| committer | Raghavendra G <rgowdapp@redhat.com> | 2017-01-09 22:28:45 -0800 |
| commit | 0e6a8452446003e9510cfad1dbece5c0b7151fdc (patch) | |
| tree | a1cec3210f29dd4f9caaef9f7e0e94f8bdea2ad8 | |
| parent | 411471c1827640fbb38813d0f870b3c85773039f (diff) | |
rpc/socket.c : Modify gf_log message in socket_poller code in case of error
Problem: In case of SSL after stopping the volume if client(mount point) is
still trying to write the data on socket then it will throw an EIO
error on that socket and given this log message is captured at every
attempt this would flood the log file.
Solution: To reduce the frequency of stored log message use GF_LOG_OCCASIONALLY
instead of gf_log.
> BUG: 1381115
> Change-Id: I66151d153c2cbfb017b3ebc4c52162278c0f537c
> Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
> Reviewed-on: http://review.gluster.org/15605
> Smoke: Gluster Build System <jenkins@build.gluster.org>
> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
> Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
> (cherry picked from commit 070145750006c87099f945b4990a4460d814c21f)
Change-Id: I9536dcb2cbf3f8082dccf049cbfb21a034f5eac1
BUG: 1384363
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: http://review.gluster.org/15632
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
| -rw-r--r-- | rpc/rpc-transport/socket/src/socket.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/rpc/rpc-transport/socket/src/socket.c b/rpc/rpc-transport/socket/src/socket.c index 8269b08279e..4a34b45cce7 100644 --- a/rpc/rpc-transport/socket/src/socket.c +++ b/rpc/rpc-transport/socket/src/socket.c @@ -2407,7 +2407,7 @@ out: return ret; } - +static int poll_err_cnt; static void * socket_poller (void *ctx) { @@ -2543,8 +2543,11 @@ socket_poller (void *ctx) break; } if (ret < 0) { - gf_log(this->name,GF_LOG_ERROR, - "error in polling loop"); + GF_LOG_OCCASIONALLY (poll_err_cnt, this->name, + GF_LOG_ERROR, + "socket_poller %s failed (%s)", + this->peerinfo.identifier, + strerror (errno)); break; } if (priv->ot_gen != gen) { |