summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarshavardhana <harsha@harshavardhana.net>2014-05-03 16:17:04 -0700
committerAnand Avati <avati@redhat.com>2014-05-03 19:40:11 -0700
commitd5918849bebc8df85b017e3eddefaef69f008889 (patch)
tree2c13a51909e3dfdb23b02ab4ec341e542f659a9f
parentaea76f0ec5ca01fd10810d704e5ad00cb4eba2fc (diff)
changelog: in C99 `inline` shouldn't be part of function definition
- C99 standard dictates that `inline` should be used only to hint function implementation not as a definition - http://clang.llvm.org/compatibility.html#inline This also leads to run time issues as 'undefined symbols' - Remember to use adding explicit headers when using an external function Change-Id: I66a9030da7ac38ded6e0b6a977182be977382fa2 BUG: 1089172 Signed-off-by: Harshavardhana <harsha@harshavardhana.net> Reviewed-on: http://review.gluster.org/7655 Reviewed-by: Anand Avati <avati@redhat.com> Tested-by: Anand Avati <avati@redhat.com>
-rw-r--r--xlators/features/changelog/src/changelog-helpers.h10
-rw-r--r--xlators/features/changelog/src/changelog.c1
2 files changed, 6 insertions, 5 deletions
diff --git a/xlators/features/changelog/src/changelog-helpers.h b/xlators/features/changelog/src/changelog-helpers.h
index 8e591e2f935..ec90f8a13d7 100644
--- a/xlators/features/changelog/src/changelog-helpers.h
+++ b/xlators/features/changelog/src/changelog-helpers.h
@@ -395,18 +395,18 @@ int
changelog_forget (xlator_t *this, inode_t *inode);
/* Geo-Rep snapshot dependency changes */
-inline void
+void
changelog_color_fop_and_inc_cnt (xlator_t *this, changelog_priv_t *priv,
changelog_local_t *local);
-inline void
+void
changelog_inc_fop_cnt (xlator_t *this, changelog_priv_t *priv,
changelog_local_t *local);
-inline void
+void
changelog_dec_fop_cnt (xlator_t *this, changelog_priv_t *priv,
changelog_local_t *local);
-inline int
+int
changelog_barrier_notify (changelog_priv_t *priv, char* buf);
-inline void
+void
changelog_barrier_cleanup (xlator_t *this, changelog_priv_t *priv,
struct list_head *queue);
void
diff --git a/xlators/features/changelog/src/changelog.c b/xlators/features/changelog/src/changelog.c
index 1253a1a6829..5eb2cd93fd3 100644
--- a/xlators/features/changelog/src/changelog.c
+++ b/xlators/features/changelog/src/changelog.c
@@ -19,6 +19,7 @@
#include "iobuf.h"
#include "changelog-rt.h"
+#include "changelog-helpers.h"
#include "changelog-encoders.h"
#include "changelog-mem-types.h"