diff options
authorRajesh Joseph <>2016-11-03 14:21:28 +0530
committerRaghavendra Talur <>2016-11-09 11:17:36 -0800
commit6c7e87cd2871ee2db0519a4598f6d15bbf3df5d2 (patch)
parentc5d2002ac2e68dc8aa7d54a32e9bd441b9b8bcfa (diff)
posix-acl: check dictionary before using it
If extended attributes are not present in md-cache it returns NULL as xattr. posix acl xlator should check for NULL before using xattr. If normal and default ACLs are not set on file then md-cache will not contain system.posix_acl_access and system.posix_acl_default extended attributes in its cache. Therefore posix_acl_lookup_cbk should check xattr before using it, otherwise the logs will get filled with dictionary errors. > Reviewed-on: > Reviewed-by: Raghavendra Talur <> > Smoke: Gluster Build System <> > Reviewed-by: jiffin tony Thottan <> > NetBSD-regression: NetBSD Build System <> > Reviewed-by: Vijay Bellur <> > CentOS-regression: Gluster Build System <> (cherry picked from commit de7fe24663713fff364cfc2b52b675e3e979ee68) Change-Id: Icebf73cf0b313bd3e82ca8cbda63786dd0fa47da BUG: 1392867 Signed-off-by: Rajesh Joseph <> Reviewed-on: NetBSD-regression: NetBSD Build System <> CentOS-regression: Gluster Build System <> Smoke: Gluster Build System <> Reviewed-by: Raghavendra Talur <>
1 files changed, 3 insertions, 0 deletions
diff --git a/xlators/system/posix-acl/src/posix-acl.c b/xlators/system/posix-acl/src/posix-acl.c
index 4841c7cb939..80cbbef09db 100644
--- a/xlators/system/posix-acl/src/posix-acl.c
+++ b/xlators/system/posix-acl/src/posix-acl.c
@@ -874,6 +874,9 @@ posix_acl_lookup_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
ret = posix_acl_get (inode, this, &old_access, &old_default);
+ if (xattr == NULL)
+ goto acl_set;
data = dict_get (xattr, POSIX_ACL_ACCESS_XATTR);
if (!data)
goto acl_default;