summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPoornima G <pgurusid@redhat.com>2016-11-04 15:56:42 +0530
committerRajesh Joseph <rjoseph@redhat.com>2016-11-18 03:20:03 -0800
commit372aeecc61f324612842658963713394aa96f885 (patch)
treeca76739c482035ce2c1a31cdace3856dd7e5322b
parent94ba6c9995d3122f31cad2f4993ab07cd6ae7063 (diff)
upcall: Fix a log level
In upcall_cache_invalidation(), the gfid can be NULL in certain valid test cases(eg: entry for ".." in readdirp), hence change the log level from WARNING to DEBUG. Backport of http://review.gluster.org/15777 > Reviewed-on: http://review.gluster.org/15777 > NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> > CentOS-regression: Gluster Build System <jenkins@build.gluster.org> > Smoke: Gluster Build System <jenkins@build.gluster.org> > Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> > Reviewed-by: Jeff Darcy <jdarcy@redhat.com> (cherry picked from commit 68d1480e6056d1be91cde5129a6809642eeee857) Change-Id: Ic90167a0e2076694e9131913114460df7b939b30 BUG: 1394188 Signed-off-by: Poornima G <pgurusid@redhat.com> Reviewed-on: http://review.gluster.org/15830 NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Smoke: Gluster Build System <jenkins@build.gluster.org>
-rw-r--r--xlators/features/upcall/src/upcall-internal.c9
1 files changed, 7 insertions, 2 deletions
diff --git a/xlators/features/upcall/src/upcall-internal.c b/xlators/features/upcall/src/upcall-internal.c
index a783c62..05b054b 100644
--- a/xlators/features/upcall/src/upcall-internal.c
+++ b/xlators/features/upcall/src/upcall-internal.c
@@ -516,8 +516,13 @@ upcall_cache_invalidate (call_frame_t *frame, xlator_t *this, client_t *client,
gf_uuid_copy (up_inode_ctx->gfid, stbuf->ia_gfid);
}
- GF_VALIDATE_OR_GOTO ("upcall_cache_invalidate",
- !(gf_uuid_is_null (up_inode_ctx->gfid)), out);
+ if (gf_uuid_is_null (up_inode_ctx->gfid)) {
+ gf_msg_debug (this->name, 0, "up_inode_ctx->gfid and "
+ "stbuf->ia_gfid is NULL, fop:%s",
+ gf_fop_list[frame->root->op]);
+ goto out;
+ }
+
pthread_mutex_lock (&up_inode_ctx->client_list_lock);
{
list_for_each_entry_safe (up_client_entry, tmp,