summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBharata B Rao <bharata@linux.vnet.ibm.com>2013-12-09 11:15:02 +0530
committerAnand Avati <avati@redhat.com>2013-12-10 09:16:30 -0800
commit00b159840added72099f61f45b38133e856d23bf (patch)
treea3c0196ddad9bef61760b37a190784f59df323c4
parentf4488e34553ec0bf68c270034af179ab14fd2b58 (diff)
libglusterfs: Explicitly open /dev/stderr logfile
Currently if stderr is specified as logfile, /dev/stderr isn't opened but stderr is directly used. However libgfapi closes the logfile (and hence stderr) from glfs_fini() which results in stderr becoming unavailable for the application that links to libgfapi. Prevent this unexpected behaviour for the application by explicitly opening /dev/stderr like it is done for any other logfile. Change-Id: I76b754598a2acf40b91ff0461726c5918e278c84 BUG: 1038924 Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com> Reviewed-on: http://review.gluster.org/6452 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@redhat.com>
-rw-r--r--libglusterfs/src/logging.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/libglusterfs/src/logging.c b/libglusterfs/src/logging.c
index 5deb90cdae2..e3a4a9fde09 100644
--- a/libglusterfs/src/logging.c
+++ b/libglusterfs/src/logging.c
@@ -373,9 +373,7 @@ gf_log_init (void *data, const char *file, const char *ident)
}
if (strcmp (file, "-") == 0) {
- ctx->log.gf_log_logfile = stderr;
- ctx->log.logfile = stderr;
- return 0;
+ file = "/dev/stderr";
}
ctx->log.filename = gf_strdup (file);