summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRaghavendra Bhat <raghavendrabhat@gluster.com>2010-05-11 03:44:16 +0000
committerAnand V. Avati <avati@dev.gluster.com>2010-05-11 10:10:06 -0700
commit663bac225369bec7603203727195cad950db8f02 (patch)
tree58291505820ed60d22f83eec9911a5396b06cd8e
parent031af4c3f44f1a791bfe3792dce0612e22dac707 (diff)
unref dict by destroying stub in server_stub_resume to avoid leak in lookup and xattrop
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 915 (memory leak in server protocol) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=915
-rw-r--r--xlators/protocol/server/src/server-protocol.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/xlators/protocol/server/src/server-protocol.c b/xlators/protocol/server/src/server-protocol.c
index f915717..20fab0d 100644
--- a/xlators/protocol/server/src/server-protocol.c
+++ b/xlators/protocol/server/src/server-protocol.c
@@ -2641,8 +2641,7 @@ server_stub_resume (call_stub_t *stub, int32_t op_ret, int32_t op_errno,
server_lookup_cbk (stub->frame, NULL,
stub->frame->this, -1, ENOENT,
NULL, NULL, NULL);
- server_loc_wipe (&stub->args.lookup.loc);
- FREE (stub);
+ call_stub_destroy(stub);
return 0;
}
@@ -2701,8 +2700,7 @@ server_stub_resume (call_stub_t *stub, int32_t op_ret, int32_t op_errno,
server_xattrop_cbk (stub->frame, NULL,
stub->frame->this, -1, ENOENT,
NULL);
- server_loc_wipe (&stub->args.xattrop.loc);
- FREE (stub);
+ call_stub_destroy(stub);
return 0;
}