summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRajesh Joseph <rjoseph@redhat.com>2013-10-31 15:34:44 +0530
committershishir gowda <sgowda@redhat.com>2013-11-15 14:45:13 +0530
commit36c2d6a02b053ac5e0584d52a6ded00bfa493db6 (patch)
tree23edad82bb208bc83f1fa31edb64331e91741978
parentea9051f32f48de658f525bb515f44e2c1e76da33 (diff)
Snapshot: fix for snapshot create crash
GL-205: Gluster snapshot create crashing. runner-arg should have NULL as the last argument. Change-Id: I1bd0090160b53a04a8073c31d91fb77f96f625dc Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-snapshot.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-snapshot.c b/xlators/mgmt/glusterd/src/glusterd-snapshot.c
index 0d12373..287a449 100644
--- a/xlators/mgmt/glusterd/src/glusterd-snapshot.c
+++ b/xlators/mgmt/glusterd/src/glusterd-snapshot.c
@@ -2286,7 +2286,7 @@ glusterd_remove_snapshot (glusterd_brickinfo_t *brickinfo, char *volname,
snprintf (msg, sizeof(msg), "remove snapshot of the brick %s:%s, "
"device: %s", brickinfo->hostname, brickinfo->path,
snap_device);
- runner_add_args (&runner, "/sbin/lvmremove", snap_device);
+ runner_add_args (&runner, "/sbin/lvmremove", snap_device, NULL);
runner_log (&runner, "", GF_LOG_DEBUG, msg);
//let glusterd get blocked till snapshot is over
@@ -2465,7 +2465,7 @@ glusterd_take_snapshot (glusterd_brickinfo_t *brickinfo, char *volname,
snprintf (msg, sizeof (msg), "taking snapshot of the brick %s:%s",
brickinfo->hostname, brickinfo->path);
runner_add_args (&runner, "/sbin/lvcreate", "-s", device, "--name",
- snapname);
+ snapname, NULL);
runner_log (&runner, "", GF_LOG_DEBUG, msg);
//let glusterd get blocked till snapshot is over