summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPoornima <pgurusid@redhat.com>2013-12-03 05:46:40 +0000
committerAnand Avati <avati@redhat.com>2013-12-03 15:17:12 -0800
commit8a0f744c461166be483f28fe9da37732586585d8 (patch)
treec521c701739d1a3fcb58012e9adefe69e85d138b
parent17312534879f506c71ee72c549ba6fda6f9b063d (diff)
cluster/afr: handle NULL check before strlen/strcmp in fgetxattr
xattr name can legally be NULL. Handle that case without crashing. Change-Id: Ie214cb05ccd52565dc247a9234ad83ae799d3866 BUG: 1036879 Signed-off-by: Poornima <pgurusid@redhat.com> Reviewed-on: http://review.gluster.org/6412 Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com> Tested-by: Gluster Build System <jenkins@build.gluster.com>
-rw-r--r--xlators/cluster/afr/src/afr-inode-read.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/cluster/afr/src/afr-inode-read.c b/xlators/cluster/afr/src/afr-inode-read.c
index ac64a7636..8a2853319 100644
--- a/xlators/cluster/afr/src/afr-inode-read.c
+++ b/xlators/cluster/afr/src/afr-inode-read.c
@@ -1405,7 +1405,7 @@ afr_is_special_xattr (const char *name, fop_getxattr_cbk_t *cbk,
gf_boolean_t is_spl = _gf_true;
GF_ASSERT (cbk);
- if (!cbk) {
+ if (!cbk || !name) {
is_spl = _gf_false;
goto out;
}