Merged HeketiBaseClass to BaseClass

Renamed cns_baseclass.py to baseclass.py with updated BaseClass.
Merged HeketiBaseClass to BaseClass with appropriate changes.
Updated delete_volumes and delete_block_volumes methods used in
test case method with heketi_delete_volume and heketi_blockvolume-
delete.

Change-Id: I8f623f1692cd863dc8ff041f7e8525ee0dc84f7b
Signed-off-by: vamahaja <vamahaja@redhat.com>

25 files changed, 161 insertions, 139 deletions

diff --git a/tests/functional/common/arbiter/test_arbiter.py b/tests/functional/common/arbiter/test_arbiter.py
index 9a701fc5..587a74d3 100644
--- a/tests/functional/common/arbiter/test_arbiter.py
+++ b/tests/functional/common/arbiter/test_arbiter.py
@@ -1,6 +1,6 @@
 import ddt
 
-from cnslibs.cns import cns_baseclass
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common import heketi_ops
 from cnslibs.common import heketi_version
 from cnslibs.common.openshift_ops import (
@@ -18,7 +18,7 @@ from cnslibs.common.openshift_ops import (
 
 
 @ddt.ddt
-class TestArbiterVolumeCreateExpandDelete(cns_baseclass.BaseClass):
+class TestArbiterVolumeCreateExpandDelete(BaseClass):
 
     def setUp(self):
         super(TestArbiterVolumeCreateExpandDelete, self).setUp()
diff --git a/tests/functional/common/gluster_block/test_restart_gluster_block.py b/tests/functional/common/gluster_block/test_restart_gluster_block.py
index be5c4e9b..90c10dec 100644
--- a/tests/functional/common/gluster_block/test_restart_gluster_block.py
+++ b/tests/functional/common/gluster_block/test_restart_gluster_block.py
@@ -1,4 +1,4 @@
-from cnslibs.common.heketi_libs import HeketiBaseClass
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common.heketi_ops import (
     heketi_blockvolume_create,
     heketi_blockvolume_delete)
@@ -9,7 +9,7 @@ from cnslibs.common.openshift_ops import (
     wait_for_resource_absence)
 
 
-class TestRestartGlusterBlockPod(HeketiBaseClass):
+class TestRestartGlusterBlockPod(BaseClass):
 
     def test_restart_gluster_block_provisioner_pod(self):
         """Restart gluster-block provisioner pod
@@ -26,13 +26,13 @@ class TestRestartGlusterBlockPod(HeketiBaseClass):
 
         # restart gluster-block-provisioner-pod
         dc_name = "glusterblock-%s-provisioner-dc" % self.storage_project_name
-        pod_name = get_pod_name_from_dc(self.ocp_master_node, dc_name)
-        oc_delete(self.ocp_master_node, 'pod', pod_name)
-        wait_for_resource_absence(self.ocp_master_node, 'pod', pod_name)
+        pod_name = get_pod_name_from_dc(self.ocp_master_node[0], dc_name)
+        oc_delete(self.ocp_master_node[0], 'pod', pod_name)
+        wait_for_resource_absence(self.ocp_master_node[0], 'pod', pod_name)
 
         # new gluster-pod name
-        pod_name = get_pod_name_from_dc(self.ocp_master_node, dc_name)
-        wait_for_pod_be_ready(self.ocp_master_node, pod_name)
+        pod_name = get_pod_name_from_dc(self.ocp_master_node[0], dc_name)
+        wait_for_pod_be_ready(self.ocp_master_node[0], pod_name)
 
         # create new heketi block volume
         vol_info = heketi_blockvolume_create(self.heketi_client_node,
diff --git a/tests/functional/common/gluster_stability/test_gluster_services_restart.py b/tests/functional/common/gluster_stability/test_gluster_services_restart.py
index 2c8603a2..2170815e 100644
--- a/tests/functional/common/gluster_stability/test_gluster_services_restart.py
+++ b/tests/functional/common/gluster_stability/test_gluster_services_restart.py
@@ -6,7 +6,7 @@ from unittest import skip
 import ddt
 from glusto.core import Glusto as g
 
-from cnslibs.cns.cns_baseclass import BaseClass
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common.heketi_ops import heketi_blockvolume_list
 from cnslibs.common.openshift_ops import (
     get_pod_name_from_dc,
diff --git a/tests/functional/common/heketi/heketi_tests/test_disabling_device.py b/tests/functional/common/heketi/heketi_tests/test_disabling_device.py
index 6139f64d..f0e2c5c6 100644
--- a/tests/functional/common/heketi/heketi_tests/test_disabling_device.py
+++ b/tests/functional/common/heketi/heketi_tests/test_disabling_device.py
@@ -2,12 +2,12 @@ from glusto.core import Glusto as g
 from glustolibs.gluster.volume_ops import get_volume_info
 
 from cnslibs.common import exceptions
-from cnslibs.common import heketi_libs
+from cnslibs.common import baseclass
 from cnslibs.common import heketi_ops
 from cnslibs.common import podcmd
 
 
-class TestDisableHeketiDevice(heketi_libs.HeketiBaseClass):
+class TestDisableHeketiDevice(baseclass.BaseClass):
     @podcmd.GlustoPod()
     def test_create_volumes_enabling_and_disabling_heketi_devices(self):
         """Validate enable/disable of heketi device"""
@@ -57,7 +57,9 @@ class TestDisableHeketiDevice(heketi_libs.HeketiBaseClass):
         self.assertTrue(out, "Failed to create heketi volume of size 1")
         g.log.info("Successfully created heketi volume of size 1")
         device_id = out["bricks"][0]["device"]
-        self.addCleanup(self.delete_volumes, [out["bricks"][0]["volume"]])
+        self.addCleanup(
+            heketi_ops.heketi_volume_delete, self.heketi_client_node,
+            self.heketi_server_url, out["bricks"][0]["volume"])
 
         # Disable device
         g.log.info("Disabling '%s' device" % device_id)
@@ -90,7 +92,8 @@ class TestDisableHeketiDevice(heketi_libs.HeketiBaseClass):
                 g.log.info("Volume was not created as expected.")
             else:
                 self.addCleanup(
-                    self.delete_volumes, [out["bricks"][0]["volume"]])
+                    heketi_ops.heketi_volume_delete, self.heketi_client_node,
+                    self.heketi_server_url, out["bricks"][0]["volume"])
                 msg = "Volume unexpectedly created. Out: %s" % out
                 assert False, msg
         finally:
@@ -116,7 +119,9 @@ class TestDisableHeketiDevice(heketi_libs.HeketiBaseClass):
         out = heketi_ops.heketi_volume_create(
             self.heketi_client_node, self.heketi_server_url, 1, json=True)
         self.assertTrue(out, "Failed to create volume of size 1")
-        self.addCleanup(self.delete_volumes, [out["bricks"][0]["volume"]])
+        self.addCleanup(
+            heketi_ops.heketi_volume_delete, self.heketi_client_node,
+            self.heketi_server_url, out["bricks"][0]["volume"])
         g.log.info("Successfully created volume of size 1")
         name = out["name"]
 
diff --git a/tests/functional/common/heketi/heketi_tests/test_heketi_create_volume.py b/tests/functional/common/heketi/heketi_tests/test_heketi_create_volume.py
index b03e5e30..c1be0d86 100644
--- a/tests/functional/common/heketi/heketi_tests/test_heketi_create_volume.py
+++ b/tests/functional/common/heketi/heketi_tests/test_heketi_create_volume.py
@@ -3,7 +3,7 @@ from glustolibs.gluster.volume_ops import get_volume_list, get_volume_info
 import six
 
 from cnslibs.common.exceptions import ExecutionError
-from cnslibs.common.heketi_libs import HeketiBaseClass
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common.heketi_ops import (heketi_volume_create,
                                        heketi_volume_list,
                                        heketi_volume_info,
@@ -13,11 +13,12 @@ from cnslibs.common.heketi_ops import (heketi_volume_create,
                                        heketi_cluster_delete,
                                        heketi_node_info,
                                        heketi_node_list,
-                                       heketi_node_delete)
+                                       heketi_node_delete,
+                                       heketi_volume_delete)
 from cnslibs.common import podcmd
 
 
-class TestHeketiVolume(HeketiBaseClass):
+class TestHeketiVolume(BaseClass):
     """
     Class to test heketi volume create
     """
@@ -45,7 +46,9 @@ class TestHeketiVolume(HeketiBaseClass):
                                    self.volume_size, json=True)
         g.log.info("Heketi volume successfully created" % out)
         volume_id = out["bricks"][0]["volume"]
-        self.addCleanup(self.delete_volumes, volume_id)
+        self.addCleanup(
+            heketi_volume_delete, self.heketi_client_node,
+            self.heketi_server_url, volume_id)
 
         g.log.info("List heketi volumes after volume creation")
         h_vol_list = heketi_volume_list(
@@ -82,7 +85,9 @@ class TestHeketiVolume(HeketiBaseClass):
                         "volume of size %s" % self.volume_size))
         g.log.info("Heketi volume successfully created" % out)
         volume_id = out["bricks"][0]["volume"]
-        self.addCleanup(self.delete_volumes, volume_id)
+        self.addCleanup(
+            heketi_volume_delete, self.heketi_client_node,
+            self.heketi_server_url, volume_id)
 
         g.log.info("Retrieving heketi volume info")
         out = heketi_volume_info(
@@ -112,7 +117,9 @@ class TestHeketiVolume(HeketiBaseClass):
                             "volume of size %s" % self.volume_size))
             g.log.info("Heketi volume successfully created" % out)
             volume_id = out["bricks"][0]["volume"]
-            self.addCleanup(self.delete_volumes, volume_id)
+            self.addCleanup(
+                heketi_volume_delete, self.heketi_client_node,
+                self.heketi_server_url, volume_id)
 
         # List heketi cluster's
         g.log.info("Listing heketi cluster list")
@@ -154,7 +161,9 @@ class TestHeketiVolume(HeketiBaseClass):
         self.assertTrue(vol, "Failed to create heketi volume.")
         g.log.info("Heketi volume successfully created")
         volume_id = vol["bricks"][0]["volume"]
-        self.addCleanup(self.delete_volumes, volume_id)
+        self.addCleanup(
+            heketi_volume_delete, self.heketi_client_node,
+            self.heketi_server_url, volume_id)
 
         # Pick up suitable node
         node_ids = heketi_node_list(self.heketi_client_node, heketi_url)
diff --git a/tests/functional/common/heketi/heketi_tests/test_node_enable_disable.py b/tests/functional/common/heketi/heketi_tests/test_node_enable_disable.py
index 9fac9e01..b8ce2c71 100644
--- a/tests/functional/common/heketi/heketi_tests/test_node_enable_disable.py
+++ b/tests/functional/common/heketi/heketi_tests/test_node_enable_disable.py
@@ -1,16 +1,18 @@
 """Test cases to disable and enable node in heketi."""
 import json
 
-from cnslibs.common.heketi_libs import HeketiBaseClass
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common.heketi_ops import (heketi_node_enable,
                                        heketi_node_info,
                                        heketi_node_disable,
                                        heketi_node_list,
-                                       heketi_volume_create)
+                                       heketi_volume_create,
+                                       heketi_volume_delete
+                                       )
 from glusto.core import Glusto as g
 
 
-class TestHeketiNodeState(HeketiBaseClass):
+class TestHeketiNodeState(BaseClass):
     """Test node enable and disable functionality."""
 
     def enable_node(self, node_id):
@@ -107,9 +109,9 @@ class TestHeketiNodeState(HeketiBaseClass):
         vol_info = heketi_volume_create(self.heketi_client_node,
                                         self.heketi_server_url, vol_size,
                                         json=True)
-        self.assertTrue(vol_info, (
-                "Failed to create heketi volume of size %d" % vol_size))
-        self.addCleanup(self.delete_volumes, vol_info['id'])
+        self.addCleanup(
+            heketi_volume_delete, self.heketi_client_node,
+            self.heketi_server_url, vol_info['id'])
 
         node_id = online_hosts[0]['id']
         g.log.info("going to disable node id %s", node_id)
@@ -122,7 +124,9 @@ class TestHeketiNodeState(HeketiBaseClass):
             vol_size, raw_cli_output=True)
         if ret == 0:
             out_json = json.loads(out)
-            self.addCleanup(self.delete_volumes, out_json["id"])
+            self.addCleanup(
+                heketi_volume_delete, self.heketi_client_node,
+                self.heketi_server_url, out_json["id"])
         self.assertNotEqual(ret, 0,
                             ("Volume creation did not fail ret- %s "
                              "out- %s err- %s" % (ret, out, err)))
@@ -135,6 +139,6 @@ class TestHeketiNodeState(HeketiBaseClass):
         vol_info = heketi_volume_create(self.heketi_client_node,
                                         self.heketi_server_url, vol_size,
                                         json=True)
-        self.assertTrue(vol_info, (
-                "Failed to create heketi volume of size %d" % vol_size))
-        self.addCleanup(self.delete_volumes, vol_info['id'])
+        self.addCleanup(
+            heketi_volume_delete, self.heketi_client_node,
+            self.heketi_server_url, vol_info['id'])
diff --git a/tests/functional/common/heketi/heketi_tests/test_node_info.py b/tests/functional/common/heketi/heketi_tests/test_node_info.py
index 3f956d62..ad60b844 100644
--- a/tests/functional/common/heketi/heketi_tests/test_node_info.py
+++ b/tests/functional/common/heketi/heketi_tests/test_node_info.py
@@ -2,11 +2,11 @@ from glusto.core import Glusto as g
 from glustolibs.gluster.exceptions import ExecutionError
 from glustolibs.gluster.peer_ops import get_pool_list
 
-from cnslibs.common.heketi_libs import HeketiBaseClass
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common import heketi_ops, podcmd
 
 
-class TestHeketiVolume(HeketiBaseClass):
+class TestHeketiVolume(BaseClass):
     """
     Class to test heketi volume create
     """
diff --git a/tests/functional/common/heketi/test_block_volumes_heketi.py b/tests/functional/common/heketi/test_block_volumes_heketi.py
index 1a460a96..b75f58ac 100644
--- a/tests/functional/common/heketi/test_block_volumes_heketi.py
+++ b/tests/functional/common/heketi/test_block_volumes_heketi.py
@@ -5,10 +5,10 @@ from cnslibs.common.heketi_ops import (heketi_blockvolume_create,
                                        heketi_volume_create,
                                        heketi_volume_delete
                                        )
-from cnslibs.common.heketi_libs import HeketiBaseClass
+from cnslibs.common.baseclass import BaseClass
 
 
-class TestBlockVolumeOps(HeketiBaseClass):
+class TestBlockVolumeOps(BaseClass):
     """Class to test heketi block volume deletion with and without block
        volumes existing, heketi block volume list, heketi block volume info
        and heketi block volume creation with name and block volumes creation
@@ -22,49 +22,44 @@ class TestBlockVolumeOps(HeketiBaseClass):
         block_host_create_info = heketi_volume_create(
             self.heketi_client_node, self.heketi_server_url, 5,
             json=True, block=True)
-        self.assertNotEqual(block_host_create_info, False,
-                            "Block host volume creation failed")
-        block_hosting_vol_id = block_host_create_info["id"]
-        self.addCleanup(self.delete_volumes, block_hosting_vol_id)
+        self.addCleanup(
+            heketi_volume_delete, self.heketi_client_node,
+            self.heketi_server_url, block_host_create_info["id"])
+
         block_vol = heketi_blockvolume_create(
             self.heketi_client_node, self.heketi_server_url, 1, json=True)
-        self.assertNotEqual(block_vol, False, "Block volume creation failed")
-        self.addCleanup(self.delete_block_volumes, block_vol["id"])
+        self.addCleanup(
+            heketi_blockvolume_delete, self.heketi_client_node,
+            self.heketi_server_url, block_vol["id"])
 
     def test_block_host_volume_delete_without_block_volumes(self):
         """Validate deletion of empty block hosting volume"""
         block_host_create_info = heketi_volume_create(
             self.heketi_client_node, self.heketi_server_url, 1, json=True,
             block=True)
-        self.assertNotEqual(block_host_create_info, False,
-                            "Block host volume creation failed")
+
         block_hosting_vol_id = block_host_create_info["id"]
-        self.addCleanup(heketi_volume_delete, self.heketi_client_node,
-                        self.heketi_server_url, block_hosting_vol_id,
-                        raise_on_error=False)
-        block_host_delete_output = heketi_volume_delete(
+        self.addCleanup(
+            heketi_volume_delete, self.heketi_client_node,
+            self.heketi_server_url, block_hosting_vol_id, raise_on_error=False)
+
+        heketi_volume_delete(
             self.heketi_client_node, self.heketi_server_url,
             block_hosting_vol_id, json=True)
-        self.assertNotEqual(
-            block_host_delete_output, False,
-            "Block host volume delete failed, ID: %s" % block_hosting_vol_id)
 
     def test_block_volume_delete(self):
         """Validate deletion of gluster-block volume and capacity of used pool
         """
         block_vol = heketi_blockvolume_create(
             self.heketi_client_node, self.heketi_server_url, 1, json=True)
-        self.assertNotEqual(block_vol, False,
-                            "Block volume creation has failed")
-        self.addCleanup(heketi_blockvolume_delete, self.heketi_client_node,
-                        self.heketi_server_url, block_vol["id"],
-                        raise_on_error=False)
-        block_delete_output = heketi_blockvolume_delete(
+        self.addCleanup(
+            heketi_blockvolume_delete, self.heketi_client_node,
+            self.heketi_server_url, block_vol["id"], raise_on_error=False)
+
+        heketi_blockvolume_delete(
             self.heketi_client_node, self.heketi_server_url,
             block_vol["id"], json=True)
-        self.assertNotEqual(block_delete_output, False,
-                            "deletion of block volume has failed, ID: %s"
-                            % block_vol["id"])
+
         volume_list = heketi_blockvolume_list(
             self.heketi_client_node, self.heketi_server_url, json=True)
         self.assertNotIn(block_vol["id"], volume_list["blockvolumes"],
@@ -76,14 +71,16 @@ class TestBlockVolumeOps(HeketiBaseClass):
         created_vol_ids = []
         for count in range(3):
             block_vol = heketi_blockvolume_create(
-                self.heketi_client_node, self.heketi_server_url,
-                1, json=True)
-            self.assertNotEqual(block_vol, False,
-                                "Block volume creation has failed")
-            self.addCleanup(self.delete_block_volumes,  block_vol["id"])
+                self.heketi_client_node, self.heketi_server_url, 1, json=True)
+            self.addCleanup(
+                heketi_blockvolume_delete, self.heketi_client_node,
+                self.heketi_server_url, block_vol["id"])
+
             created_vol_ids.append(block_vol["id"])
+
         volumes = heketi_blockvolume_list(
             self.heketi_client_node, self.heketi_server_url, json=True)
+
         existing_vol_ids = volumes.values()[0]
         for vol_id in created_vol_ids:
             self.assertIn(vol_id, existing_vol_ids,
diff --git a/tests/functional/common/heketi/test_check_entries.py b/tests/functional/common/heketi/test_check_entries.py
index e8479226..12fc21a2 100644
--- a/tests/functional/common/heketi/test_check_entries.py
+++ b/tests/functional/common/heketi/test_check_entries.py
@@ -1,17 +1,17 @@
 from glusto.core import Glusto as g
 
-from cnslibs.common.heketi_libs import HeketiBaseClass
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common.heketi_ops import (heketi_volume_create,
                                        heketi_volume_delete)
 from cnslibs.common.openshift_ops import get_ocp_gluster_pod_names
 
 
-class TestHeketiVolume(HeketiBaseClass):
+class TestHeketiVolume(BaseClass):
     """Check volume bricks presence in fstab files on Gluster PODs."""
 
     def _find_bricks_in_fstab_files(self, brick_paths, present):
         """Make sure that vol brick paths either exist or not in fstab file."""
-        oc_node = self.ocp_master_nodes[0]
+        oc_node = self.ocp_master_node[0]
         gluster_pods = get_ocp_gluster_pod_names(oc_node)
         get_fstab_entries_cmd = "oc exec %s -- cat /var/lib/heketi/fstab"
         fstab_files_data = ''
diff --git a/tests/functional/common/heketi/test_create_distributed_replica_heketi_volume.py b/tests/functional/common/heketi/test_create_distributed_replica_heketi_volume.py
index c79ae5ee..93ef0593 100644
--- a/tests/functional/common/heketi/test_create_distributed_replica_heketi_volume.py
+++ b/tests/functional/common/heketi/test_create_distributed_replica_heketi_volume.py
@@ -5,7 +5,7 @@ from glusto.core import Glusto as g
 from glustolibs.gluster.volume_ops import get_volume_list, get_volume_info
 
 from cnslibs.common import exceptions
-from cnslibs.common.heketi_libs import HeketiBaseClass
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common.heketi_ops import (heketi_node_list,
                                        heketi_node_enable,
                                        heketi_node_disable,
@@ -18,7 +18,7 @@ from cnslibs.common.heketi_ops import (heketi_node_list,
 from cnslibs.common import podcmd
 
 
-class TestHeketiVolume(HeketiBaseClass):
+class TestHeketiVolume(BaseClass):
 
     def setUp(self):
         super(TestHeketiVolume, self).setUp()
diff --git a/tests/functional/common/heketi/test_device_info.py b/tests/functional/common/heketi/test_device_info.py
index d1214537..a48fd814 100644
--- a/tests/functional/common/heketi/test_device_info.py
+++ b/tests/functional/common/heketi/test_device_info.py
@@ -1,8 +1,8 @@
-from cnslibs.common import heketi_libs
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common import heketi_ops
 
 
-class TestHeketiDeviceInfo(heketi_libs.HeketiBaseClass):
+class TestHeketiDeviceInfo(BaseClass):
 
     def test_heketi_devices_info_verification(self):
         """Validate whether device related information is displayed"""
diff --git a/tests/functional/common/heketi/test_heketi_device_operations.py b/tests/functional/common/heketi/test_heketi_device_operations.py
index 0ad81f48..8bd87089 100644
--- a/tests/functional/common/heketi/test_heketi_device_operations.py
+++ b/tests/functional/common/heketi/test_heketi_device_operations.py
@@ -4,7 +4,7 @@ import ddt
 from glusto.core import Glusto as g
 
 from cnslibs.common.exceptions import ExecutionError
-from cnslibs.common.heketi_libs import HeketiBaseClass
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common.heketi_ops import (heketi_node_enable,
                                        heketi_node_info,
                                        heketi_node_disable,
@@ -16,11 +16,12 @@ from cnslibs.common.heketi_ops import (heketi_node_enable,
                                        heketi_device_remove,
                                        heketi_device_info,
                                        heketi_device_enable,
-                                       heketi_topology_info)
+                                       heketi_topology_info,
+                                       heketi_volume_delete)
 
 
 @ddt.ddt
-class TestHeketiDeviceOperations(HeketiBaseClass):
+class TestHeketiDeviceOperations(BaseClass):
     """Test Heketi device enable/disable and remove functionality."""
 
     def check_any_of_bricks_present_in_device(self, bricks, device_id):
@@ -124,7 +125,9 @@ class TestHeketiDeviceOperations(HeketiBaseClass):
                                         json=True)
         self.assertTrue(vol_info, (
             "Failed to create heketi volume of size %d" % vol_size))
-        self.addCleanup(self.delete_volumes, vol_info['id'])
+        self.addCleanup(
+            heketi_volume_delete, self.heketi_client_node,
+            self.heketi_server_url, vol_info['id'])
 
         # Check that one of volume's bricks is present on the device
         present = self.check_any_of_bricks_present_in_device(
@@ -144,7 +147,9 @@ class TestHeketiDeviceOperations(HeketiBaseClass):
             self.heketi_client_node, self.heketi_server_url,
             vol_size, json=True, raw_cli_output=True)
         if ret == 0:
-            self.addCleanup(self.delete_volumes, json.loads(out)["id"])
+            self.addCleanup(
+                heketi_volume_delete, self.heketi_client_node,
+                self.heketi_server_url, json.loads(out)["id"])
         self.assertNotEqual(ret, 0,
                             ("Volume creation did not fail. ret- %s "
                              "out- %s err- %s" % (ret, out, err)))
@@ -159,9 +164,9 @@ class TestHeketiDeviceOperations(HeketiBaseClass):
         vol_info = heketi_volume_create(self.heketi_client_node,
                                         self.heketi_server_url, vol_size,
                                         json=True)
-        self.assertTrue(vol_info, (
-            "Failed to create heketi volume of size %d" % vol_size))
-        self.addCleanup(self.delete_volumes, vol_info['id'])
+        self.addCleanup(
+            heketi_volume_delete, self.heketi_client_node,
+            self.heketi_server_url, vol_info['id'])
 
         # Check that one of volume's bricks is present on the device
         present = self.check_any_of_bricks_present_in_device(
@@ -226,9 +231,9 @@ class TestHeketiDeviceOperations(HeketiBaseClass):
         vol_info = heketi_volume_create(
             self.heketi_client_node, self.heketi_server_url, vol_size,
             json=True)
-        self.assertTrue(vol_info, (
-            "Failed to create heketi volume of size %d" % vol_size))
-        self.addCleanup(self.delete_volumes, vol_info['id'])
+        self.addCleanup(
+            heketi_volume_delete, self.heketi_client_node,
+            self.heketi_server_url, vol_info['id'])
 
         # Add extra device, then remember it's ID and size
         heketi_device_add(self.heketi_client_node, self.heketi_server_url,
@@ -310,9 +315,9 @@ class TestHeketiDeviceOperations(HeketiBaseClass):
         vol_info = heketi_volume_create(self.heketi_client_node,
                                         self.heketi_server_url, vol_size,
                                         json=True)
-        self.assertTrue(vol_info, (
-                "Failed to create heketi volume of size %d" % vol_size))
-        self.addCleanup(self.delete_volumes, vol_info['id'])
+        self.addCleanup(
+            heketi_volume_delete, self.heketi_client_node,
+            self.heketi_server_url, vol_info['id'])
 
         if delete_device:
             return
@@ -391,7 +396,9 @@ class TestHeketiDeviceOperations(HeketiBaseClass):
             vol_size_gb -= 1
             heketi_vol = heketi_volume_create(
                 heketi_node, heketi_url, vol_size_gb, json=True)
-        self.addCleanup(self.delete_volumes, heketi_vol["bricks"][0]["volume"])
+        self.addCleanup(
+            heketi_volume_delete, self.heketi_client_node,
+            self.heketi_server_url, heketi_vol["bricks"][0]["volume"])
 
         # Try to 'remove' bigger Heketi disk expecting error,
         # because there is no space on smaller disk to relocate bricks to
diff --git a/tests/functional/common/heketi/test_heketi_metrics.py b/tests/functional/common/heketi/test_heketi_metrics.py
index 701f7d81..4653caee 100644
--- a/tests/functional/common/heketi/test_heketi_metrics.py
+++ b/tests/functional/common/heketi/test_heketi_metrics.py
@@ -1,5 +1,5 @@
 from cnslibs.common import exceptions
-from cnslibs.common.heketi_libs import HeketiBaseClass
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common.heketi_ops import (
     get_heketi_metrics,
     heketi_cluster_info,
@@ -17,7 +17,7 @@ from cnslibs.common.openshift_ops import (
     )
 
 
-class TestHeketiMetrics(HeketiBaseClass):
+class TestHeketiMetrics(BaseClass):
 
     def setUp(self):
         self.node = self.ocp_master_node[0]
@@ -177,9 +177,9 @@ class TestHeketiMetrics(HeketiBaseClass):
     def test_heketi_metrics_heketipod_failure(self):
         """Validate heketi metrics after heketi pod failure"""
         scale_dc_pod_amount_and_wait(
-            self.ocp_master_node, self.heketi_dc_name, pod_amount=0)
+            self.ocp_master_node[0], self.heketi_dc_name, pod_amount=0)
         self.addCleanup(
-            scale_dc_pod_amount_and_wait, self.ocp_master_node,
+            scale_dc_pod_amount_and_wait, self.ocp_master_node[0],
             self.heketi_dc_name, pod_amount=1)
 
         # verify that metrics is not accessable when heketi pod is down
@@ -190,11 +190,11 @@ class TestHeketiMetrics(HeketiBaseClass):
                 prometheus_format=True)
 
         scale_dc_pod_amount_and_wait(
-            self.ocp_master_node, self.heketi_dc_name, pod_amount=1)
+            self.ocp_master_node[0], self.heketi_dc_name, pod_amount=1)
 
         pod_name = get_pod_name_from_dc(
-            self.ocp_master_node, self.heketi_dc_name, self.heketi_dc_name)
-        wait_for_pod_be_ready(self.ocp_master_node, pod_name, wait_step=5)
+            self.ocp_master_node[0], self.heketi_dc_name, self.heketi_dc_name)
+        wait_for_pod_be_ready(self.ocp_master_node[0], pod_name, wait_step=5)
 
         for i in range(3):
             vol = heketi_volume_create(
diff --git a/tests/functional/common/heketi/test_heketi_volume_operations.py b/tests/functional/common/heketi/test_heketi_volume_operations.py
index f82521c5..d7b9aa18 100644
--- a/tests/functional/common/heketi/test_heketi_volume_operations.py
+++ b/tests/functional/common/heketi/test_heketi_volume_operations.py
@@ -2,10 +2,10 @@ from cnslibs.common.heketi_ops import (heketi_volume_delete,
                                        heketi_volume_create,
                                        heketi_volume_expand,
                                        heketi_volume_info)
-from cnslibs.common.heketi_libs import HeketiBaseClass
+from cnslibs.common.baseclass import BaseClass
 
 
-class TestHeketiVolumeOperations(HeketiBaseClass):
+class TestHeketiVolumeOperations(BaseClass):
     """
     Class to test heketi volume operations - create, expand
     """
diff --git a/tests/functional/common/heketi/test_server_state_examine_gluster.py b/tests/functional/common/heketi/test_server_state_examine_gluster.py
index 5b904e8f..f74366ed 100644
--- a/tests/functional/common/heketi/test_server_state_examine_gluster.py
+++ b/tests/functional/common/heketi/test_server_state_examine_gluster.py
@@ -1,10 +1,10 @@
-from cnslibs.cns import cns_baseclass
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common import heketi_ops
 from cnslibs.common import heketi_version
 from cnslibs.common import openshift_ops
 
 
-class TestHeketiServerStateExamineGluster(cns_baseclass.BaseClass):
+class TestHeketiServerStateExamineGluster(BaseClass):
 
     def setUp(self):
         self.node = self.ocp_master_node[0]
diff --git a/tests/functional/common/heketi/test_volume_creation.py b/tests/functional/common/heketi/test_volume_creation.py
index 5820b789..86618505 100644
--- a/tests/functional/common/heketi/test_volume_creation.py
+++ b/tests/functional/common/heketi/test_volume_creation.py
@@ -2,12 +2,12 @@ from glusto.core import Glusto as g
 from glustolibs.gluster import volume_ops
 
 from cnslibs.common import exceptions
-from cnslibs.common import heketi_libs
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common import heketi_ops
 from cnslibs.common import podcmd
 
 
-class TestVolumeCreationTestCases(heketi_libs.HeketiBaseClass):
+class TestVolumeCreationTestCases(BaseClass):
     """
     Class for volume creation related test cases
     """
@@ -29,7 +29,9 @@ class TestVolumeCreationTestCases(heketi_libs.HeketiBaseClass):
         volume_name = output_dict["name"]
         volume_id = output_dict["id"]
 
-        self.addCleanup(self.delete_volumes, volume_id)
+        self.addCleanup(
+            heketi_ops.heketi_volume_delete, self.heketi_client_node,
+            self.heketi_server_url, volume_id)
 
         self.assertEqual(output_dict["durability"]
                          ["replicate"]["replica"], 3,
@@ -127,7 +129,9 @@ class TestVolumeCreationTestCases(heketi_libs.HeketiBaseClass):
 
         # Create first small volume
         vol = heketi_ops.heketi_volume_create(node, server_url, 1, json=True)
-        self.addCleanup(self.delete_volumes, vol["id"])
+        self.addCleanup(
+            heketi_ops.heketi_volume_delete, self.heketi_client_node,
+            self.heketi_server_url, vol["id"])
 
         # Try to create second volume getting "no free space" error
         try:
@@ -137,7 +141,8 @@ class TestVolumeCreationTestCases(heketi_libs.HeketiBaseClass):
             g.log.info("Volume was not created as expected.")
         else:
             self.addCleanup(
-                self.delete_volumes, vol_fail["bricks"][0]["volume"])
+                heketi_ops.heketi_volume_delete, self.heketi_client_node,
+                self.heketi_server_url, vol_fail["bricks"][0]["volume"])
             self.assertFalse(
                 vol_fail,
                 "Volume should have not been created. Out: %s" % vol_fail)
diff --git a/tests/functional/common/heketi/test_volume_deletion.py b/tests/functional/common/heketi/test_volume_deletion.py
index b1be795b..6f279899 100644
--- a/tests/functional/common/heketi/test_volume_deletion.py
+++ b/tests/functional/common/heketi/test_volume_deletion.py
@@ -1,11 +1,11 @@
 from __future__ import division
 
 from cnslibs.common.exceptions import ExecutionError
-from cnslibs.common.heketi_libs import HeketiBaseClass
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common import heketi_ops
 
 
-class TestVolumeDeleteTestCases(HeketiBaseClass):
+class TestVolumeDeleteTestCases(BaseClass):
     """
     Class for volume deletion related test cases
 
@@ -40,18 +40,12 @@ class TestVolumeDeleteTestCases(HeketiBaseClass):
             self.heketi_client_node,
             self.heketi_server_url, 10, json=True)
 
-        self.assertNotEqual(creation_output_dict, False,
-                            "Volume creation failed")
-
         volume_id = creation_output_dict["name"].strip().split("_")[1]
         free_space_after_creation = self.get_free_space_summary_devices()
 
-        deletion_output = heketi_ops.heketi_volume_delete(
+        heketi_ops.heketi_volume_delete(
             self.heketi_client_node, self.heketi_server_url, volume_id)
 
-        self.assertNotEqual(deletion_output, False,
-                            "Deletion of volume failed, id: %s" % volume_id)
-
         free_space_after_deletion = self.get_free_space_summary_devices()
 
         self.assertTrue(
@@ -62,7 +56,6 @@ class TestVolumeDeleteTestCases(HeketiBaseClass):
         """
         Method to test heketidb volume deletion via heketi-cli
         """
-        volume_id_list = []
         heketidbexists = False
         msg = "Error: Cannot delete volume containing the Heketi database"
 
@@ -70,18 +63,15 @@ class TestVolumeDeleteTestCases(HeketiBaseClass):
             volume_info = heketi_ops.heketi_volume_create(
                 self.heketi_client_node, self.heketi_server_url,
                 10, json=True)
-            self.assertNotEqual(volume_info, False, "Volume creation failed")
-            volume_id_list.append(volume_info["id"])
 
-        self.addCleanup(self.delete_volumes, volume_id_list)
+            self.addCleanup(
+                heketi_ops.heketi_volume_delete, self.heketi_client_node,
+                self.heketi_server_url, volume_info["id"])
 
         volume_list_info = heketi_ops.heketi_volume_list(
             self.heketi_client_node,
             self.heketi_server_url, json=True)
 
-        self.assertNotEqual(volume_list_info, False,
-                            "Heketi volume list command failed")
-
         if volume_list_info["volumes"] == []:
             raise ExecutionError("Heketi volume list empty")
 
diff --git a/tests/functional/common/heketi/test_volume_expansion_and_devices.py b/tests/functional/common/heketi/test_volume_expansion_and_devices.py
index 279be053..5e189e49 100644
--- a/tests/functional/common/heketi/test_volume_expansion_and_devices.py
+++ b/tests/functional/common/heketi/test_volume_expansion_and_devices.py
@@ -5,11 +5,11 @@ from glusto.core import Glusto as g
 from glustolibs.gluster import volume_ops, rebalance_ops
 
 from cnslibs.common.exceptions import ExecutionError
-from cnslibs.common.heketi_libs import HeketiBaseClass
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common import heketi_ops, podcmd
 
 
-class TestVolumeExpansionAndDevicesTestCases(HeketiBaseClass):
+class TestVolumeExpansionAndDevicesTestCases(BaseClass):
     """
     Class for volume expansion and devices addition related test cases
     """
diff --git a/tests/functional/common/heketi/test_volume_multi_req.py b/tests/functional/common/heketi/test_volume_multi_req.py
index 5b72cc91..f6b0fcf6 100644
--- a/tests/functional/common/heketi/test_volume_multi_req.py
+++ b/tests/functional/common/heketi/test_volume_multi_req.py
@@ -11,7 +11,7 @@ import yaml
 
 from glusto.core import Glusto as g
 
-from cnslibs.common.heketi_libs import HeketiBaseClass
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common.heketi_ops import (
     heketi_volume_list)
 from cnslibs.common.naming import (
@@ -192,7 +192,7 @@ def _heketi_name_id_map(vols):
 
 
 @ddt.ddt
-class TestVolumeMultiReq(HeketiBaseClass):
+class TestVolumeMultiReq(BaseClass):
     def setUp(self):
         super(TestVolumeMultiReq, self).setUp()
         self.volcount = self._count_vols()
diff --git a/tests/functional/common/provisioning/test_dynamic_provisioning_block_p0_cases.py b/tests/functional/common/provisioning/test_dynamic_provisioning_block_p0_cases.py
index bca0bf66..4f045356 100644
--- a/tests/functional/common/provisioning/test_dynamic_provisioning_block_p0_cases.py
+++ b/tests/functional/common/provisioning/test_dynamic_provisioning_block_p0_cases.py
@@ -1,6 +1,6 @@
 from unittest import skip
 
-from cnslibs.cns.cns_baseclass import GlusterBlockBaseClass
+from cnslibs.common.baseclass import GlusterBlockBaseClass
 from cnslibs.common.exceptions import ExecutionError
 from cnslibs.common.openshift_ops import (
     get_gluster_pod_names_by_pvc_name,
diff --git a/tests/functional/common/provisioning/test_dynamic_provisioning_p0_cases.py b/tests/functional/common/provisioning/test_dynamic_provisioning_p0_cases.py
index 81329e08..3367bab2 100644
--- a/tests/functional/common/provisioning/test_dynamic_provisioning_p0_cases.py
+++ b/tests/functional/common/provisioning/test_dynamic_provisioning_p0_cases.py
@@ -1,7 +1,7 @@
 import time
 from unittest import skip
 
-from cnslibs.cns.cns_baseclass import BaseClass
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common.exceptions import ExecutionError
 from cnslibs.common.heketi_ops import (
     verify_volume_name_prefix)
diff --git a/tests/functional/common/provisioning/test_pv_resize.py b/tests/functional/common/provisioning/test_pv_resize.py
index 99c1e451..9490ce61 100644
--- a/tests/functional/common/provisioning/test_pv_resize.py
+++ b/tests/functional/common/provisioning/test_pv_resize.py
@@ -16,7 +16,7 @@ from cnslibs.common.openshift_ops import (
     wait_for_pod_be_ready,
     wait_for_resource_absence)
 from cnslibs.common.openshift_version import get_openshift_version
-from cnslibs.cns.cns_baseclass import BaseClass
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common.exceptions import ExecutionError
 from glusto.core import Glusto as g
 
diff --git a/tests/functional/common/provisioning/test_storage_class_cases.py b/tests/functional/common/provisioning/test_storage_class_cases.py
index e9dc8dbe..f7ccd65b 100644
--- a/tests/functional/common/provisioning/test_storage_class_cases.py
+++ b/tests/functional/common/provisioning/test_storage_class_cases.py
@@ -3,7 +3,7 @@ from unittest import skip
 import ddt
 from glusto.core import Glusto as g
 
-from cnslibs.cns import cns_baseclass
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common.cns_libs import validate_multipath_pod
 from cnslibs.common.openshift_ops import (
     get_amount_of_gluster_nodes,
@@ -22,7 +22,7 @@ from cnslibs.common.openshift_ops import (
 
 
 @ddt.ddt
-class TestStorageClassCases(cns_baseclass.BaseClass):
+class TestStorageClassCases(BaseClass):
 
     def create_sc_with_parameter(self, vol_type, success=False, parameter={}):
         """creates storage class, pvc and validates event
diff --git a/tests/functional/common/test_heketi_restart.py b/tests/functional/common/test_heketi_restart.py
index 6e9f2115..a06bf9c6 100644
--- a/tests/functional/common/test_heketi_restart.py
+++ b/tests/functional/common/test_heketi_restart.py
@@ -1,10 +1,12 @@
 from jsondiff import diff
 
-from cnslibs.common.heketi_libs import HeketiBaseClass
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common.heketi_ops import (
+    heketi_topology_info,
     hello_heketi,
     heketi_volume_create,
-    heketi_topology_info)
+    heketi_volume_delete
+)
 from cnslibs.common.openshift_ops import (
     get_pod_name_from_dc,
     oc_delete,
@@ -12,7 +14,7 @@ from cnslibs.common.openshift_ops import (
     wait_for_resource_absence)
 
 
-class TestRestartHeketi(HeketiBaseClass):
+class TestRestartHeketi(BaseClass):
 
     def test_restart_heketi_pod(self):
         """Validate restarting heketi pod"""
@@ -22,24 +24,26 @@ class TestRestartHeketi(HeketiBaseClass):
                                         self.heketi_server_url,
                                         size=1, json=True)
         self.assertTrue(vol_info, "Failed to create heketi volume of size 1")
-        self.addCleanup(self.delete_volumes, vol_info['id'])
+        self.addCleanup(
+            heketi_volume_delete, self.heketi_client_node,
+            self.heketi_server_url, vol_info['id'], raise_on_error=False)
         topo_info = heketi_topology_info(self.heketi_client_node,
                                          self.heketi_server_url,
                                          json=True)
 
         # get heketi-pod name
-        heketi_pod_name = get_pod_name_from_dc(self.ocp_master_node,
+        heketi_pod_name = get_pod_name_from_dc(self.ocp_master_node[0],
                                                self.heketi_dc_name)
 
         # delete heketi-pod (it restarts the pod)
-        oc_delete(self.ocp_master_node, 'pod', heketi_pod_name)
-        wait_for_resource_absence(self.ocp_master_node,
+        oc_delete(self.ocp_master_node[0], 'pod', heketi_pod_name)
+        wait_for_resource_absence(self.ocp_master_node[0],
                                   'pod', heketi_pod_name)
 
         # get new heketi-pod name
-        heketi_pod_name = get_pod_name_from_dc(self.ocp_master_node,
+        heketi_pod_name = get_pod_name_from_dc(self.ocp_master_node[0],
                                                self.heketi_dc_name)
-        wait_for_pod_be_ready(self.ocp_master_node,
+        wait_for_pod_be_ready(self.ocp_master_node[0],
                               heketi_pod_name)
 
         # check heketi server is running
@@ -60,4 +64,5 @@ class TestRestartHeketi(HeketiBaseClass):
                                         self.heketi_server_url,
                                         size=2, json=True)
         self.assertTrue(vol_info, "Failed to create heketi volume of size 20")
-        self.delete_volumes(vol_info['id'])
+        heketi_volume_delete(
+            self.heketi_client_node, self.heketi_server_url, vol_info['id'])
diff --git a/tests/functional/common/test_node_restart.py b/tests/functional/common/test_node_restart.py
index fc8bec07..6a0969ee 100644
--- a/tests/functional/common/test_node_restart.py
+++ b/tests/functional/common/test_node_restart.py
@@ -2,7 +2,7 @@
 import time
 
 from unittest import skip
-from cnslibs.cns.cns_baseclass import BaseClass
+from cnslibs.common.baseclass import BaseClass
 from cnslibs.common.openshift_ops import (
     check_service_status_on_pod,
     get_ocp_gluster_pod_names,