Rework 'heketi_ops' module

Doing following:
- Remove dead code with usage of Heketi python lib.
  Because it is not used and not tested.
- Remove unused functions in general.
- Make existing functions raise exceptions with CLI error message
  instead of returning 'False' boolean value hiding info about
  original errors.

Change-Id: I1f0def567dd77425397ff2c8ba13f9c0640af5bc

1 files changed, 5 insertions, 11 deletions

diff --git a/tests/functional/common/heketi/test_volume_expansion_and_devices.py b/tests/functional/common/heketi/test_volume_expansion_and_devices.py
index 8e8dea9a..a003ceb7 100644
--- a/tests/functional/common/heketi/test_volume_expansion_and_devices.py
+++ b/tests/functional/common/heketi/test_volume_expansion_and_devices.py
@@ -542,17 +542,11 @@ class TestVolumeExpansionAndDevicesTestCases(HeketiBaseClass):
 
         free_space_after_creation = self.get_devices_summary_free_space()
 
-        ret, out, err = heketi_ops.heketi_volume_expand(
-            self.heketi_client_node, self.heketi_server_url,
-            volume_id, 50, raw_cli_output=True)
-
-        self.assertEqual(ret, 255, "volume expansion did not fail ret- %s "
-                         "out- %s err= %s" % (ret, out, err))
-        g.log.info("Volume expansion failed as expected, err- %s" % err)
-
-        if ret == 0:
-            out_json = json.loads(out)
-            self.addCleanup(self.delete_volumes, out_json["id"])
+        self.assertRaises(
+            ExecutionError,
+            heketi_ops.heketi_volume_expand,
+            self.heketi_client_node, self.heketi_server_url, volume_id,
+            50, raw_cli_output=True)
 
         self.enable_devices(additional_devices_attached)