path: root/rpc/rpc-transport
diff options
authorKrutika Dhananjay <>2012-10-15 17:04:29 +0530
committerVijay Bellur <>2012-11-12 07:08:35 -0800
commit009c728b401287ef9aa9ee4a7fb509ccc5baa156 (patch)
tree4b947e8a93e9c66a13b4feaf938a4c5476a3b8cd /rpc/rpc-transport
parent7997d36ce3d37b0b3ac33c1529f03969442b6595 (diff)
glusterd: Fixed glusterd crash in volume add-brick
PROBLEMS: a. glusterd crashes when add-brick operation fails on the machine other than the originator, owing to double free done on op_errstr: once in glusterd_op_begin_synctask and once through a dict unref on req_dict in gd_sync_task_begin. b. In gd_sync_task_begin, there's no need to place the error string in the dictionary, when it is never retrieved and used elsewhere. c. Command execution status is not logged into .cmd_log_history. FIX: For (a) and (b): Knocked off code that places the error string in req_dict. That way, both the problems are solved. For (b), passed op_ctx to glusterd_op_send_cli_response as it is needed to extract the command string before logging. Change-Id: I549a07ba5e31332b691a8cacd1ab32c2673810ba BUG: 862834 Signed-off-by: Krutika Dhananjay <> Reviewed-on: Reviewed-by: Krishnan Parthasarathi <> Reviewed-by: Pranith Kumar Karampuri <> Tested-by: Gluster Build System <>
Diffstat (limited to 'rpc/rpc-transport')
0 files changed, 0 insertions, 0 deletions