summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* fix spec fileHEADmasterPrasanna Kumar Kalever2018-03-064-6/+19
| | | | | | | also other minor compiler errors Change-Id: I17625008d91740f3ba9efc6e574ec3dcd0b6c85f Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* info: show failed nodesPrasanna Kumar Kalever2018-03-051-16/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | $ cat /mnt/block-meta/block VOLUME: sample GBID: 9d278e06-b2d1-4050-bd92-c8e8b40a5654 HA: 3 ENTRYCREATE: INPROGRESS SIZE: 9663676416 ENTRYCREATE: SUCCESS 192.168.0.104: CONFIGSUCCESS 192.168.0.105: CONFIGFAIL 192.168.0.106: CLEANUPFAIL $ gluster-block info sample/block NAME: block VOLUME: sample GBID: 9d278e06-b2d1-4050-bd92-c8e8b40a5654 SIZE: 9.0 GiB HA: 3 PASSWORD: EXPORTED ON: 192.168.0.104 ENCOUNTERED FAILURES ON: 192.168.0.105 192.168.0.106 $ gluster-block info sample/block --json-pretty { "NAME":"block", "VOLUME":"sample", "GBID":"9d278e06-b2d1-4050-bd92-c8e8b40a5654", "SIZE":"9.0 GiB", "HA":3, "PASSWORD":"", "EXPORTED ON":[ "192.168.0.104" ], "ENCOUNTERED FAILURES ON":[ "192.168.0.105", "192.168.0.106" ] } Change-Id: I3d47e75f64719b9eeab661006bf4ccaa629a8408 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* create: split "ROLLBACK ON:" to SUCCESS and FAILUREPrasanna Kumar Kalever2018-03-051-30/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | Ex: When 192.168.124.179 goes while create is in progress, $ gluster-block create sample/1 ha 3 192.168.124.208,192.168.124.8,\ 192.168.124.179 1GiB --json-pretty; { "IQN":"iqn.2016-12.org.gluster-block:451cfb72-bf63-45ce-83d9-d059c010cbdd", "PORTAL(S)":[ "192.168.124.208:3260", "192.168.124.8:3260", "192.168.124.179:3260" ], "ROLLBACK FAILED ON":[ "192.168.124.179" ], "ROLLBACK SUCCESS ON":[ "192.168.124.8", "192.168.124.208" ], "RESULT":"FAIL" } Change-Id: Ibb947304154055f7477b80f1850184fb1965416d Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* doc: update README about starting Open-iSCSI servicePrasanna Kumar Kalever2018-03-051-0/+3
| | | | | Change-Id: Ifc02424dd5009be8303d75fabc0292fa68b27dc7 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* script: remote code decide b/w run|skip the cmdPrasanna Kumar Kalever2018-02-191-60/+86
| | | | | Change-Id: Ia20b69a9ec5c18ee2165f4c3e0e4ee244c68a3e9 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* delete: support [unlink-storage <yes|no>] optionPrasanna Kumar Kalever2018-02-083-23/+47
| | | | | | | | | | | | | | | | | | | | $ gluster-block help gluster-block (0.3) usage: gluster-block <command> <volname[/blockname]> [<args>] [--json*] commands: [...] delete <volname/blockname> [unlink-storage <yes|no>] [force] delete block device. [...] supported JSON formats: --json|--json-plain|--json-spaced|--json-pretty Change-Id: I64bc99a8519be6f90a7e8bc5558b0d7518661995 Fixes: #19 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* create: support [storage <filename>] optionPrasanna Kumar Kalever2018-02-086-49/+163
| | | | | | | | | | | | | | | | | | | | | | $ gluster-block help gluster-block (0.3) usage: gluster-block <command> <volname[/blockname]> [<args>] [--json*] commands: create <volname/blockname> [ha <count>] [auth <enable|disable>] [prealloc <full|no>] [storage <filename>] <host1[,host2,...]> <size> create block device [defaults: ha 1, auth disable, prealloc no, size in bytes] [...] supported JSON formats: --json|--json-plain|--json-spaced|--json-pretty Fixes: #18 Change-Id: I5d9b4abb58596bd2297cffb294c6d31f752d53e9 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* replace strcat and strcpy with their secure versionsPrasanna Kumar Kalever2018-02-088-73/+106
| | | | | Change-Id: If98ce7b7e50901ee130bbe190a12664ec0adb8c2 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* replace: add replace featurePrasanna Kumar Kalever2018-02-0710-276/+1451
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. create conf in new node 2. delete conf from old node 3. replace portals from nodes hosting other paths (HA) $ gluster-block create sample/block ha 3 192.168.124.57,192.168.124.26,192.168.124.30 1GiB --json-pretty { "IQN":"iqn.2016-12.org.gluster-block:d516bb5c-5f56-4d9c-96a7-385df19c2e2c", "PORTAL(S)":[ "192.168.124.57:3260", "192.168.124.26:3260", "192.168.124.30:3260" ], "RESULT":"SUCCESS" } $ gluster-block help gluster-block (0.3) usage: gluster-block <command> <volname[/blockname]> [<args>] [--json*] commands: [...] replace <volname/blockname> <old-node> <new-node> [force] replace operations. [...] supported JSON formats: --json|--json-plain|--json-spaced|--json-pretty $ gluster-block replace sample/block 192.168.124.26 192.168.124.56 --json-pretty { "NAME":"block", "CREATE SUCCESS":"192.168.124.56", "DELETE SUCCESS":"192.168.124.26", "REPLACE PORTAL SUCCESS ON":[ "192.168.124.57", "192.168.124.30" ], "RESULT":"SUCCESS" } Fixes: #4 Change-Id: I0411d15c407111db0d423052d9a6bc075174bf90 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* gluster-block: Fix build error due to couldn't find the glfs.hXiubo Li2018-01-211-1/+1
| | | | | | | | | | | | | | When using the newest glusterfs.git, this project couldn't be build successfully due to lacking the glfs.h header file. More detail please see glusterfs's commit: 684d62276af37c260671024ce17cb281f493b289 This will still be compatible with older glusterfs's versions. BUG: 1536908 Change-Id: Ie27a4921daa2b2f989488b167188a9b13569806a Signed-off-by: Xiubo Li <lixiubo@cmss.chinamobile.com>
* versioning: add capabilities supportPrasanna Kumar Kalever2018-01-187-29/+741
| | | | | Change-Id: Ic63f7c9fa169ee37b796093554c59016fbbfaa46 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* configure: fix compiling error for lacking of AM_PROG_CC_C_O in configure.acXiubo Li2018-01-031-0/+3
| | | | | | | | Added the AM_PROG_CC_C_O macro although it is obsolete since automake 1.14. But as automake < 1.14 is still out there. Change-Id: Id6e0db318068a65c6cb9c2bfb0c32af4eb4a9b70 Signed-off-by: Xiubo Li <lixiubo@cmss.chinamobile.com>
* cli: make unit prefixes case insensitiveMichael Adam2017-12-213-12/+10
| | | | | Change-Id: I28544d08217f15b90c3e439bfd9aa75ba0432d07 Signed-off-by: Michael Adam <obnox@redhat.com>
* cli: Be more strict about what size units we expect.Michael Adam2017-12-121-5/+18
| | | | | | | | | | Only accept b,B,k(iB),K(iB),M(iB),G(iB),T(iB),... Fail on all other with an improved error message. Resolves: https://github.com/gluster/gluster-block/issues/44 Change-Id: I6ac7e9359f3b8d8afaad254ea12c30131ed676d8 Signed-off-by: Michael Adam <obnox@redhat.com>
* extras: add script for replace nodePrasanna Kumar Kalever2017-12-071-0/+550
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | $ for i in {1..3}; do echo "block${i}:"; gluster-block create test/block$i ha 3 192.168.124.208,192.168.124.8,192.168.124.179 1MiB --json-pretty; done block1: { "IQN":"iqn.2016-12.org.gluster-block:ccc8f04b-1498-4c55-b27b-a1c500799d7b", "PORTAL(S)":[ "192.168.124.208:3260", "192.168.124.8:3260", "192.168.124.179:3260" ], "RESULT":"SUCCESS" } block2: { "IQN":"iqn.2016-12.org.gluster-block:a081f36d-ba9a-4679-a7d5-a6c9b5add2c0", "PORTAL(S)":[ "192.168.124.208:3260", "192.168.124.8:3260", "192.168.124.179:3260" ], "RESULT":"SUCCESS" } block3: { "IQN":"iqn.2016-12.org.gluster-block:53525e2d-c69d-4770-a645-f60847b9190d", "PORTAL(S)":[ "192.168.124.208:3260", "192.168.124.8:3260", "192.168.124.179:3260" ], "RESULT":"SUCCESS" } $ gluster-block list test --json-pretty{ "blocks":[ "block1", "block2", "block3" ], "RESULT":"SUCCESS" } $ ./replace-node.sh help Usage: ./replace-node.sh ${MOUNTPOINT} ${OLDNODE} ${NEWNODE} $ ./replace-node.sh /mnt/test 192.168.124.179 192.168.124.128 Fuse mount point, does not have directory '/mnt/test/block-meta/' Usage: ./replace-node.sh ${MOUNTPOINT} ${OLDNODE} ${NEWNODE} $ mount.glusterfs localhost:/test /mnt/test $ ./replace-node.sh /mnt/test/ 192.168.124.179 192.168.124.128 blockname: block1 create on '192.168.124.128' success replace on '192.168.124.208' success replace on '192.168.124.8' success delete on '192.168.124.179' success ------------------------------------- blockname: block2 create on '192.168.124.128' success replace on '192.168.124.208' success replace on '192.168.124.8' success delete on '192.168.124.179' success ------------------------------------- blockname: block3 create on '192.168.124.128' success replace on '192.168.124.208' success replace on '192.168.124.8' success delete on '192.168.124.179' success ------------------------------------- Change-Id: I68ce36063accfdc1f56c8f160b8c4dd4ca58afe7 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* Update version in INSTALLVijay Bellur2017-11-141-2/+2
| | | | Change-Id: I138739d52b064fcf14d0a9239e91fa6af5c017c6
* doc: describe how to contribute when a GitHub Pull-Request is madeNiels de Vos2017-11-091-0/+30
| | | | | | | | | | gluster-block does not use GitHub Pull-Requests. However not all developers are aware of this, so showing a note whenever someone creates a Pull-Request should inform them. Change-Id: Ibc717a3d578946b1d260c5a7af6e828b810887d1 URL: https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/ Signed-off-by: Niels de Vos <ndevos@redhat.com>
* NEWS: updatev0.3Prasanna Kumar Kalever2017-10-131-21/+14
| | | | | Change-Id: I7b1b4ca913dd04b6578423e258d76f9062542b4d Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* cli: defend on minimum block sizePrasanna Kumar Kalever2017-10-092-2/+8
| | | | | | | | | | | | | | | | | From, $ targetcli /backstores/user:glfs/block get attribute ATTRIBUTE CONFIG GROUP ====================== hw_block_size=512 [ro] ---------------------- Hence making the min acceptable size to be 1 sector/block i.e. 512 bytes This patch also, explicitly mention in docs about bytes as default size units. Change-Id: Iec8797082d02cc9ad51fc17e11f2ba3073aaeda0 Fixes: #35 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* delete/rollback: check for matching gbid before deleting a blockPrasanna Kumar Kalever2017-10-091-3/+9
| | | | | | | | | | | | | | | Currently we are just checking for blockname in targetcli list output, if it exist we will delete the backend. We do not check if block belongs to a given volume (say vol1), because of which a rollback on a failure to create block with same name, on same node but on a different volume (say vol2) deletes block backend belonging to vol1. Solution: only if blockname + gbid matches continue delete. Change-Id: I396c228dad3cf4f51cc6676a266b837bdf6040c7 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* spec: fix unclosed %if blockPrasanna Kumar Kalever2017-09-251-0/+4
| | | | | Change-Id: Iab80dd7fea69eb28630ed563fda4db72ceeaadbe Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* rpm: include suggested changes from Fedora package reviewNiels de Vos2017-09-221-7/+25
| | | | | | | | | | | | | | | | | | gluster-block has been packaged for Fedora and reviewing the .spec showed some areas where improvements could be done. The following changes are part of the Fedora package, so it would be good to include them here as well: - added systemd macros in the scriptlets - use pkgconfig for BuildRequires - run setup in quiet mode - run make_* macros instead of make commands in build/install section - drop the INSTALL file from the documentation Change-Id: Ic0d28eb900aabd2199b6a021db3790ec023cdf25 URL: https://src.fedoraproject.org/rpms/gluster-block BUG: https://bugzilla.redhat.com/1467677 Signed-off-by: Niels de Vos <ndevos@redhat.com>
* dist: supports initd for non-systemd distrosJi-Hyeon Gim2017-09-215-6/+178
| | | | | | | | | | | | Problem gluster-blockd supports systemd officially but many legacy distros want to use initd Resolve includes initd scripts for non-systemd distros Change-Id: I8495e8d9abbef6d26ac7dc8dbbe6d07e7713f537 Signed-off-by: Ji-Hyeon Gim <potatogim@gluesys.com>
* configure: make sysconfig directory configurableMichael Adam2017-09-201-1/+6
| | | | | | | | | | | This is currently hard-coded to /etc/sysconfig, which makes it impossible to entirely install under a prefix. This patch introduces a new switch --with-sysconfigdir defaulting to /etc/sysconfig, which lets one reconfiure the sysconfig directory. Change-Id: I316f8355c3ddcfece3322f30a45108bdc636637d Signed-off-by: Michael Adam <obnox@redhat.com>
* build: do not require 'git' to find the versionNiels de Vos2017-09-193-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | While looking into packaging gluster-block for Fedora, I noticed that 'git' is used to determine the version. The downloads from GitHub are not archives that have been created with 'make dist', and hence ./autogen.sh is still needed to be run. ./autogen.sh generates all the needed bits, including the ./configure script that tries to figure out the version. If ./configure runs in a non-git directory, no version can be found. In order to solve this, I'm adding a VERSION file in the root of the project. If this file exists, it is used to fetch the version, instead of trying to run git. The basic usage for RPM packaging in distributions can then be: echo %{version} > VERSION ./autogen.sh %configure Note that the VERSION file is not needed for building from a git repository. However, this file can get packaged in the 'make dist' tarball so that building from the tarball does not require git. Change-Id: Ied378c7071ee4a108a1e946dccbb7f223b7aeb9f Updates: #25 Signed-off-by: Niels de Vos <ndevos@redhat.com>
* daemon: set configshell file loglevel to infoPrasanna Kumar Kalever2017-09-191-3/+3
| | | | | Change-Id: I64fa708bacff138423a490853e7c50c046a0ad28 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* socket: switch to MT-safe get host addr infoPrasanna Kumar Kalever2017-09-192-30/+51
| | | | | | | | This was fixed in an attempt to clean the sockfd leaks Change-Id: Icd82635134050c83167a48b451b347f5c2b9bf39 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com> Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
* rpc: switch to MT-safe block RPC routinesPrasanna Kumar Kalever2017-09-194-42/+149
| | | | | | | | | | | | | | | | | | | | | | | | | | blockResponse * block_delete_1(blockDelete *argp, CLIENT *clnt) { static blockResponse clnt_res; <<<<<<-------- Same memory is used by everyone memset((char *)&clnt_res, 0, sizeof(clnt_res)); <<<<<---- Here memset is happening if (clnt_call (clnt, BLOCK_DELETE, (xdrproc_t) xdr_blockDelete, (caddr_t) argp, (xdrproc_t) xdr_blockResponse, (caddr_t) &clnt_res, TIMEOUT) != RPC_SUCCESS) { return (NULL); } return (&clnt_res); <<<<<---- ptr to this memory is returned. } So while Thread-1 is returned "return (&clnt_res);" another thread could be doing "memset((char *)&clnt_res, 0, sizeof(clnt_res));" This seem to be a day-1 gluster-blockd bug from the looks of it. Change-Id: I3fc76d7814c4fe5b286577586ec44d752dcc73f0 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com> Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
* gluster-block: missing to include signal.hJi-Hyeon Gim2017-09-181-0/+1
| | | | | | | | Problem gluster-blockd using POSIX signal handling but it not includes signal.h Change-Id: Iecb3a17d70226a894bfe9a6fb5b8382d87afde7f Signed-off-by: Ji-Hyeon Gim <potatogim@potatogim.net>
* configure: add gluster-block-target.service to AC_CONFIG_FILES listPrasanna Kumar Kalever2017-09-153-3/+4
| | | | | Change-Id: I9ab049253c013fd23e9065e5a35451aea4ef4e52 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* systemd: fix systemd dependency listPrasanna Kumar Kalever2017-09-155-5/+26
| | | | | | | | | | | | | This patch brings a wrapper target service unit 'gluster-block-target.service' which ensures tcmu-runner gets activated. To fix this properly we need a change in tcmu-runner [1] unit which has to define precedence of glusterd service. [1] https://github.com/open-iscsi/tcmu-runner/pull/296 Change-Id: I32d7d82eec03e0cc9111eb58241190af30244a3c Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* docs: fix error in gluster-blockd manpageMichael Adam2017-09-151-2/+2
| | | | | | | Examples used --glfs-cache-count instead of --glfs-lru-count. Change-Id: Ia45cb32d91ff4f4490a64ab014212c0e7aa9fb7c Signed-off-by: Michael Adam <obnox@redhat.com>
* fix GB_TGCLI_GLOBALS macroPrasanna Kumar Kalever2017-09-011-2/+2
| | | | | | | | change in GB_TGCLI_GLOBALS macro: 's/set global/targetcli set global/' followed by a saveconfig Change-Id: I634f9ecbd7171828cb0da01314deeec99c4dfced Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* misc: fix warningsPrasanna Kumar Kalever2017-08-292-12/+7
| | | | | Change-Id: I11274ad59925ec3d034baefc2cc2e307afa45479 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* gluster-block: parse remote command outputsPrasanna Kumar Kalever2017-08-282-94/+191
| | | | | Change-Id: Ic2317843a8bd882fc26233373a4b4c35b13f24c6 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* gluster-block: use targetcli interactive modePrasanna Kumar Kalever2017-08-284-212/+140
| | | | | | | | | | | | | | | | | | Currently, on each targetcli create call, rtslib will rebuild its bs_cache, so as the /sys/kernel/config/target/core dir gets more entries this takes longer and longer to scan. Hence using repetitive targetcli in the block create for creating iqn, backend, setting acls, setting globals will induce too much delay in block create. As the number of blocks on the node increases, the delay will be too longer. This does not happen if we open targetcli in interactive mode and just do multiple create commands form it, since the bs_cache is build once. Read More: https://goo.gl/8aYT38 Change-Id: I2be78a748e013f253ce8f99746989a1cf735a56f Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* rpc: use port 24010 for all gluster-blockd managementPrasanna Kumar Kalever2017-08-242-2/+2
| | | | | | | | | | | | | | | | | It looks like 24006 port is already registered by some other service, and from [1] it looks like 24007 - 24241 are unassigned. Currently, 24007 -> glusterd (tcp) 24008 -> glusterd (rdma) 24009 -> glustereventsd so for gluster-blockd communications lets choose port 24010 [1] https://goo.gl/B2A4RU Change-Id: I7d9f14b9897e479cececd2271ebf8a975d26ef71 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* configure: fix indentation of --with-systemddirMichael Adam2017-08-211-1/+2
| | | | | | | by using AC_HELP_STRING Change-Id: I07130e15e2689d6c2ea9a21dfb7e8e2511838976 Signed-off-by: Michael Adam <obnox@redhat.com>
* logger: support logdir choosing via Environment variablePrasanna Kumar Kalever2017-08-177-64/+123
| | | | | | | | | | | | Currently the default logdir is DATADIR /log/gluster-block/ This patch will provide a way to change this default logdir via Env variable $ export GB_LOGDIR=/var/log/gluster-block-new-path/ Note: make sure to restart the processes (cli & daemon) after you set GB_LOGDIR Change-Id: Id142e4a4dfe7b6ebc9cf8296b8ceb8bff37691b8 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* gluster-block: support force delete optionPrasanna Kumar Kalever2017-08-084-24/+45
| | | | | | | | | | | | | | | | $ gluster-block help gluster-block (0.2.1) usage: gluster-block <command> <volname[/blockname]> [<args>] [--json*] commands: [...] delete <volname/blockname> [force] delete block device. [...] Change-Id: I64ac01ec148e2e1d4d0ba0d4c5560df9334d58f5 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* gluster-block: do not allow delete if any node is downPrasanna Kumar Kalever2017-08-031-19/+155
| | | | | Change-Id: If729b80a8139add989170d3b590e92706128c37e Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* create: move saveconfig out of the loopPrasanna Kumar Kalever2017-07-131-8/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the previous patch, `commit f2e46779c0175e5063ce07256023f1977b333f2d Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com> Date: Fri Jul 7 15:51:38 2017 +0530 tcmu: backstore attribute set cmd_time_out=0 [...]` unintentionally saveconfig was left inside the loop. Hence fixing this by pushing it outside. Problem: Currently, while populating 'exec' variable the following line after saveconfig i.e. at line GB_FREE(tmp); the 'tmp' variable is made NULL; Hence in each loop, condition if(!tmp) is always true, and the 'else' set of statements will never be executed. Impact: On block create with HA > 1, only for Nth(last) node portal gets created for rest of the nodes portal and their attr will never be created/set. As a result block is not exported correctly. Also, remove duplicated DEVNULLPATH redirection with attr setting Change-Id: I1f77461de6b89af4e4af098e0444ea3526669030 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* tcmu: backstore attribute set cmd_time_out=0Prasanna Kumar Kalever2017-07-071-5/+19
| | | | | | | | | | | | | currently, runner is not supporting the non-zero cmd timeouts (cmd_time_out !=0) The tcmu cmd timer just fails the kernel command after cmd_time_out seconds, leaving the runner command running. When it is zero, it means do not run the timer, so both the kernel and runner wait for the command to complete. This patch sets the backstore attribute cmd_time_out=0 Change-Id: Ib7a80c82d0aafe345ff4e79ce88dc92848306f4e Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* cli: show 'prealloc' option in the hint msgPrasanna Kumar Kalever2017-07-071-2/+3
| | | | | | | | | | | $ gluster-block create Inadequate arguments for create: gluster-block create <volname/blockname> [ha <count>] [auth<enable|disable>] \ [prealloc <full|no>] <HOST1[,HOST2,...]> <size> [--json*] Change-Id: Ib089598fd9b386bd3475dd421b41c45ebb01c9d2 Fixes: #33 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* create: clean metafile along with storage when EntryCreate failsPrasanna Kumar Kalever2017-07-062-4/+13
| | | | | | | | | | | As of now, if an EntryCreate (backend storage create) fails for some reasons like no space left, we only clean storage, leaving metafile. This patch will delete metafile along with backend storage from the volume. Change-Id: I89247b98602c5b991367f671134de496c294f984 Fixes: #32 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* utils: fix trivial compile warningNiels de Vos2017-07-041-1/+1
| | | | | | | | | | | | The following warning is reported with Fedora Rawhide (F-27) that comes with an updated gcc version (7.1.1): utils.c:217:21: warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context] if (!tmp && (size * count)) { ~~~~~~^~~~~~~~ Change-Id: If1645e0e1cc1eaa1d8261914918c5a5be13d6dd8 Signed-off-by: Niels de Vos <ndevos@redhat.com>
* Show error message when response contains failurePranith Kumar K2017-06-301-4/+19
| | | | | Change-Id: If7a232e4a1d550b3912402282c21d0d033aa00d2 Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
* gluster-block: update systemd unit and spec filePrasanna Kumar Kalever2017-06-272-2/+6
| | | | | | | | | | | systemd-unit: iscsid.service is needed by initiator not target spec: update with missing dependencies Change-Id: I58bd3d8b60fac10eeb2a7d5cd4fc6f827da1d7b4 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* dist: do not package the rpcgen generated filesPrasanna Kumar Kalever2017-06-241-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | This patch fixes rpcgen file stat issue. rpcgen, before generating a file, it first stats the file, in case if file already exists, it do not try to override, instead bails out. [...] Making all in rpcl make[3]: Entering directory `/builddir/build/BUILD/gluster-block-0.2.1/rpc/rpcl' rpcgen -h -o ../../rpc/rpcl/block.h block.x file `../../rpc/rpcl/block.h' already exists and may be overwritten make[3]: Leaving directory `/builddir/build/BUILD/gluster-block-0.2.1/rpc/rpcl' make[3]: *** [block.h] Error 1 [...] So the fix will be not to package the rpcgen generated file in the source tarball. Change-Id: I1d136a25c49aeea2d84e96bf065fe46bf0214a13 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* Don't let LOG segfault if log dir does not exist - fall back to stderr.Michael Adam2017-06-221-0/+6
| | | | | Change-Id: I65ad54381362280d9a5596e48aa3242f1160fd2d Signed-off-by: Michael Adam <obnox@redhat.com>
generated by cgit (git 2.34.1) at 2024-04-25 06:21:03 +0000