diff options
author | Prasanna Kumar Kalever <prasanna.kalever@redhat.com> | 2017-07-13 00:01:36 +0530 |
---|---|---|
committer | Prasanna Kumar Kalever <prasanna.kalever@redhat.com> | 2017-07-13 00:31:54 +0530 |
commit | c6295a4e56375e252a43f34d7d6fa8a804a9a732 (patch) | |
tree | fa5cf4178bbe99ac07ccb2541644cefbf9ed1370 /rpc/rpcl/block.x | |
parent | f2e46779c0175e5063ce07256023f1977b333f2d (diff) |
create: move saveconfig out of the loop
In the previous patch,
`commit f2e46779c0175e5063ce07256023f1977b333f2d
Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Date: Fri Jul 7 15:51:38 2017 +0530
tcmu: backstore attribute set cmd_time_out=0
[...]`
unintentionally saveconfig was left inside the loop. Hence fixing this by
pushing it outside.
Problem:
Currently, while populating 'exec' variable the following line after saveconfig
i.e. at line GB_FREE(tmp); the 'tmp' variable is made NULL; Hence in each
loop, condition if(!tmp) is always true, and the 'else' set of statements will
never be executed.
Impact:
On block create with HA > 1, only for Nth(last) node portal gets created for
rest of the nodes portal and their attr will never be created/set. As a
result block is not exported correctly.
Also, remove duplicated DEVNULLPATH redirection with attr setting
Change-Id: I1f77461de6b89af4e4af098e0444ea3526669030
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Diffstat (limited to 'rpc/rpcl/block.x')
0 files changed, 0 insertions, 0 deletions