| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
As glfs and glfd are pointers to memory locations, passing invalid
values of glfs and glfd to the libgfapi C library can result in
segfault. This patch introduces decorators that validate glfs
and glfd before calling correspoding C APIs.
Change-Id: I4e86bd8e436e23cd41f75f428d246939c820bb9c
Signed-off-by: Prashanth Pai <ppai@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch:
* Implements Volume.utime() which is very similar to os.utime() present
in Python. https://docs.python.org/2/library/os.html#os.utime
* Implements File.zerofill() which exposes glfs_zerofill.
* Fixes function prototype of fallocate and discard. Adds functional
tests for the same.
Change-Id: Icb8d3a571998c31d6bf9b139ca253af59f6fc3f4
Signed-off-by: Prashanth Pai <ppai@redhat.com>
|
|\ |
|
| |
| |
| |
| |
| | |
Change-Id: I96b6f2a501d52d66694e67990d6b65d4eb920fa2
Signed-off-by: Prashanth Pai <ppai@redhat.com>
|
|/
|
|
|
|
|
|
|
|
| |
readinto()
This method is useful when you have to read a large file over multiple
read calls. While read() allocates a buffer every time it's invoked,
readinto() copies data to an already allocated buffer passed to it.
Change-Id: Ic8a3aa0e544e09e05101c983b329c91864832e4a
Signed-off-by: Prashanth Pai <ppai@redhat.com>
|
|
|
|
|
|
|
| |
This change also fixes a mismatch in glfs_seek() function signature.
Change-Id: I3d336a2fbfec9ba921b253f6d97616485cadec98
Signed-off-by: Prashanth Pai <ppai@redhat.com>
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Without this change, user (developer) will have to modify test.conf
(tracked by git) every time he has to run functional tests or has to
edit /etc/hosts and add entry for 'gfshost'
Change-Id: I6d41a657b0cae614513e2925e73138da46ddaf04
Signed-off-by: Prashanth Pai <ppai@redhat.com>
|
|/
|
|
|
|
|
|
|
|
| |
Updated tests to include OSError messages
Added error reasons to LibgfapiException exceptions
BUG 1196161: https://bugzilla.redhat.com/show_bug.cgi?id=1196161
Change-Id: Iddf40751696874ffcaa50cd9d5ecc06c4993baf2
Signed-off-by: Prashanth Pai <ppai@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this patch, calling Volume.{f}open in a thread other than main
thread was causing segmentation fault (test included). The reason is
missing ctypes declarations.
Also, this patch fixes errno handling for these two functions, making
couple of FIXME/TODO notes go away.
Change-Id: Iae9638b7d16cc0e0c587fd21a94be677f2d4af59
Signed-off-by: Oleksiy Syvokon <oleksiy.syvokon@gmail.com>
|
|
|
|
|
| |
Change-Id: Ica8a7443fa398d9c02e1658700dc067155e0913e
Signed-off-by: Thiago da Silva <thiago@redhat.com>
|
|
|
|
| |
Change-Id: Iced9bb59a33c38964e012f9d6c9ef13efc1f184c
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As per the current code, this is the behavior:
>>> with v.fopen("/abc", 'r') as f:
... data = f.read(5)
>>> print data
<ctypes.c_char_Array_2 object at 0x7fda7d6bbb90>
>>> print data.value
hello
>>>
It's incorrect to return a ctypes internal object back to the user.
In Python 2.x, read() always returns a string. It's really upto
the consumer to decode this string into whatever encoding it was
written with.
This patch reverts parts of this old change:
Ia2bb47343880cbf7121fed9510e4cfa085fe23bd
Change-Id: Ia1d3e5834be2b856776bd3cf8382a17ffd61d5df
Signed-off-by: Prashanth Pai <ppai@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Added commonly used path based operations that were missing from
the Volume class.
* Fixed function prototypes at places where it should be ssize_t
and not size_t. This caused overflow error at times.
* Added doc strings wherever they were missing.
Change-Id: I6ce28038da3cd0f89ab075045bb4092dd95e21c4
Signed-off-by: Prashanth Pai <ppai@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Volume.fopen() method mimics Python's built-in File object
Example:
with v.fopen("/path/to/file", "w") as f:
f.write("hello world")
fopen() returns a File object.
Volume.open() method mimics os.open() Python API.
Example:
with File(v.open("/path/to/file", os.O_WRONLY | os.O_CREAT)) as f:
f.write("hello world")
open() returns the raw glfd that (as of today) needs to be passed to File class.
In future, more APIs will be provided to directly use the glfd returned.
Unlike their C versions, these methods do not return
anything on success. If methods fail, exceptions are raised.
Added docstrings to methods in File class.
Change-Id: Ie46fc77a899806d396762e6740e1538ea298d6e2
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Signed-off-by: Thiago da Silva <thiago@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
* Validate inputs during initialization of Volume object.
* Move glfs_new() and glfs_init() into mount() method.
* Provide user consumable unmount() method.
* Provide "mounted" property to Volume object. Users can now check state
whether a volume is virtual mounted or not.
Change-Id: Idc53ee7f9386ed995315bd5fb492a7d36f44875f
Signed-off-by: Prashanth Pai <ppai@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
This project has to be shipped as rpm for various distributions like
Fedora,Centos,RHEL.etc, so that the clients like vdsm, openstack..etc
can make use of python bindings of libgfapi library of GlusterFS.
This patch introduce first version of the spec file for this project.
Change-Id: Icb5d83fc8b278a3cd7b89d55b5fda15a84c2fa82
Signed-off-by: Humble Devassy Chirammal <hchiramm@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The goal is to consolidate all gluster related python packages
under single namespace "gluster".
From client's perspective, it was:
from glusterfs import gfapi
Henceforth, it wil be:
from gluster import gfapi
Change-Id: If2509f570563ae7660892963607c9474313f803c
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Did not add functional tests at the moment. This function requires
superuser privilege to execute
Change-Id: I35c0a6b3eba60586da64ccfb4dc818d403542f41
Signed-off-by: Thiago da Silva <thiago@redhat.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Added option to read whole file if caller send -1
as the buflen to read function.
Also added a copy of getsize to File class, now called
fgetsize, which returns the size of the file as
reported by fstat
Removed flags paramater from read function as it is never
used by libgfapi.
Change-Id: Ia1c04ef9717d9ca098e1961300d6ee216381c989
Signed-off-by: Thiago da Silva <thiago@redhat.com>
Signed-off-by: Prashanth Pai <ppai@redhat.com>
|
|/
|
|
|
| |
Change-Id: Iba5f4e72a257adeb8ec78b267dfdef26a1ec66f1
Signed-off-by: Thiago da Silva <thiago@redhat.com>
|
|
|
|
|
|
|
| |
tests were failing due to an issue with loremipsum package
Change-Id: I9c364f48dc7fb642f5cd7a6371a53a0aa137618b
Signed-off-by: Thiago da Silva <thiago@redhat.com>
|
|
|
|
|
|
|
|
|
| |
This helps ctypes know the calling conventions it should use to communicate
with the binary interface of libgfapi and which types it should allocate and
cast. Without it, ctypes fails/crashes when not running on the main thread.
Change-Id: I73480229f451167377ed4d1534b08b66c689cc4f
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* The order of elements in list returned by listdir() can vary and may
not be sorted. This caused assertEqual in "test_listdir" to fail.
* Also, some systems may have xattrs belonging to selinux. So, a
listxattr can list them too.
* Allow hostname/ip and volume name to be configured easily by setting
it in test.conf. This enables functional tests to use a non-local volume.
* Cleanup volume before and after running functional tests.
* Added MANIFEST.in and LICENSE file
Change-Id: Icfa6eb60e8d8e7ed4d6ab8190a2a2c80688999a3
Signed-off-by: Prashanth Pai <ppai@redhat.com>
|
|
|
|
|
|
|
|
| |
This support will help other consumers to get the statvfs
details.
Change-Id: Iee4e84a515ff80f24add812ad6fcf84c992bf356
Signed-off-by: hchiramm <hchiramm@redhat.com>
|
|
|
|
|
|
|
|
| |
This patch adds new functions that are used in gluster-swift.
These functions are: dup, lseek, getatime, getctime, getmtime
Change-Id: I09036f7e393a89e09913f7f6de173e1eca8dca95
Signed-off-by: Thiago da Silva <thiago@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
the os python module does not offer a creat function,
new files are created using the open function and
by passing O_CREAT flag. We are changing gfapi.py to
function the same way.
Change-Id: I5e084b200bb657e3124d3e620a47160e790cd1fe
Signed-off-by: Thiago da Silva <thiago@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
making this change to avoid package conflicts with
gluster-swift and glusterfs-api rpm. Eventually we will remove
the python code from glusterfs-api rpm and create a new rpm package
from libgfapi-python.
Change-Id: I1b20cd747e500aed17fba89f96e62423325b5230
Signed-off-by: Thiago da Silva <thiago@redhat.com>
|
|
|
|
|
|
|
| |
These new functions are required to be used by gluster-swift
Change-Id: Ifb68f2b4494bf375feabb130831f9e076dc5b94a
Signed-off-by: Thiago da Silva <thiago@redhat.com>
|
|
|
|
|
|
|
| |
Added same license as gluster-swift
Change-Id: Ib190b4e6def5d2ab87b71a04142f6344060d8a6d
Signed-off-by: Thiago da Silva <thiago@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
These are mostly helper methods similar to functions provided
by the python os module
helpfer functions added: exists, getsize, isdir, isfile, islink
glfs functions added: removexattr, stat
Change-Id: I3581a96224151481292a4e506d8c52b8acf79e49
Signed-off-by: Thiago da Silva <thiago@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
both functions were only supporting text data and needed to be
changed to support binary data.
The issue was found while testing libgfapi-python with smallfile
(https://github.com/bengland2/smallfile).
When calling gflfs_write, ctypes has no problem converting strings
to the correct C data type, but is unable to handle bytearray:
b = bytearray(1024)
with vol.create(path, os.O_WRONLY | os.O_EXCL, 0644) as fd:
fd.write(b)
It would throw this error:
exception: argument 2: <type 'exceptions.TypeError'>:
Don't know how to convert parameter 2
reference: http://docs.python.org/2/library/ctypes.html#calling-functions-continued
Change-Id: Ia2bb47343880cbf7121fed9510e4cfa085fe23bd
Signed-off-by: Thiago da Silva <thiago@redhat.com>
|
|
|
|
|
|
|
|
| |
add mode parameter to mkdir to allow setting the dir access
mode when the directory is being created
Change-Id: I6f1ed0c8800fb65a30448e6082cf55b8220a06d4
Signed-off-by: Thiago da Silva <thiago@redhat.com>
|
|
|
|
|
|
|
|
| |
adding a few functional tests and removing old
tests from source code
Change-Id: Iefcb091d614f2825592943cfb42847b5865322c6
Signed-off-by: Thiago da Silva <thiago@redhat.com>
|
|
|
|
|
|
|
|
|
| |
when creating or opening a File, caller should now
use python's with statement as specified on PEP 343:
http://www.python.org/dev/peps/pep-0343/
Change-Id: Id98613e310bea01a427769d3ad7b0dea97245b04
Signed-off-by: Thiago da Silva <thiago@redhat.com>
|
|
|
|
|
|
|
| |
added unit tests for existing methods
Change-Id: Iecd31bc1dea44ea38168120bd05ca505c4ff5c59
Signed-off-by: Thiago da Silva <thiago@redhat.com>
|
|
This initial commit is a copy from
gluster/api/examples/gfapi.py from the glusterfs repo
Signed-off-by: Thiago da Silva <thiago@redhat.com>
Change-Id: I4442528d5bc2ec52ed2970b818d8cb9327e36168
|