From 8c59a588c903cc1a70ea769e78e0414c69006b35 Mon Sep 17 00:00:00 2001
From: Shireesh Anjal <shireesh@gluster.com>
Date: Mon, 27 Jun 2011 19:17:00 +0530
Subject: REST API enhancements

---
 .../src/get_volume_brick_log.py                    | 38 ++++++++--------------
 1 file changed, 14 insertions(+), 24 deletions(-)

(limited to 'src/com.gluster.storage.management.server.scripts')

diff --git a/src/com.gluster.storage.management.server.scripts/src/get_volume_brick_log.py b/src/com.gluster.storage.management.server.scripts/src/get_volume_brick_log.py
index 7c912412..64a40df3 100755
--- a/src/com.gluster.storage.management.server.scripts/src/get_volume_brick_log.py
+++ b/src/com.gluster.storage.management.server.scripts/src/get_volume_brick_log.py
@@ -19,7 +19,7 @@
 import re
 import os
 import sys
-from XmlHandler import ResponseXml
+from XmlHandler import XDOM
 
 def enumLogType(logCode):
     if "M" == logCode.upper():
@@ -44,12 +44,10 @@ def enumLogType(logCode):
         return "UNKNOWN"
 ##--end of enumLogType()
 
-def addLog(responseDom, logMessageTag, loginfo):
-    logTag = responseDom.createTag("logMessage", None)
-    logTag.appendChild(responseDom.createTag("timestamp", loginfo[0] + " " + loginfo[1]))
-    logTag.appendChild(responseDom.createTag("severity", enumLogType(loginfo[2])))
-    logTag.appendChild(responseDom.createTag("message", loginfo[3]))
-    logMessageTag.appendChild(logTag)
+def addLog(responseDom, loginfo):
+    responseDom.appendTagRoute("logMessages.logMessage.timestamp", loginfo[0] + " " + loginfo[1])
+    responseDom.appendTagRoute("logMessages.logMessage.severity", enumLogType(loginfo[2]))
+    responseDom.appendTagRoute("logMessages.logMessage.message", loginfo[3])
     return True
 ##--end of addLog()
 
@@ -61,26 +59,21 @@ def logSplit(log):
 ##--end of logSplit()
 
 def getVolumeLog(logFilePath, tailCount):
-    rs = ResponseXml()
+    rs = XDOM()
     if not logFilePath:
-        rs.appendTagRoute("status.code", "-1")
-        rs.appendTagRoute("status.message", "No log file path given")
-        return rs.toprettyxml()
+        print >> sys.stderr, "No log file path given"
+        sys.exit(-1);
 
     if not tailCount:
-        rs.appendTagRoute("status.code", "-1")
-        rs.appendTagRoute("status.message", "No tail count given")
-        return rs.toprettyxml()
+        print >> sys.stderr, "No tail count given"
+        sys.exit(-1);
 
     pattern = '\[\d{4}-\d{2}-\d{2}\s{1}\d{2}:\d{2}:\d{2}.\d+\]\s{1}([MACEWNIDT]){1}\s+'
-    logMessagesTag = rs.createTag("logMessages")
     if not os.path.exists(logFilePath):
-        rs.appendTagRoute("status.code", "-1")
-        rs.appendTagRoute("status.message", "volume log file [%s] not found!" % logFilePath)
-        return rs.toprettyxml
+        print >> sys.stderr, "volume log file [%s] not found!" % logFilePath
+        sys.exit(-1);
 
     fp = open(logFilePath)
-    #lines = [line for line in fp]
     lines = [line for line in fp if re.match(pattern, line)]
     fp.close()
     i = len(lines) - int(tailCount)
@@ -88,11 +81,8 @@ def getVolumeLog(logFilePath, tailCount):
         i = 0
     for log in lines[i:]:
         loginfo = logSplit(log)
-        addLog(rs, logMessagesTag, loginfo)
-    rs.appendTagRoute("status.code", "0")
-    rs.appendTagRoute("status.message", "Success")
-    rs.appendTag(logMessagesTag)
-    return rs.toprettyxml()
+        addLog(rs, loginfo)
+    return rs.toxml()
 ##--end of getVolumeLog()
 
 def main():
-- 
cgit 


From 0aa85e9e8b67492fbf26e761f54ca282539116e8 Mon Sep 17 00:00:00 2001
From: Shireesh Anjal <shireesh@gluster.com>
Date: Tue, 28 Jun 2011 14:27:07 +0530
Subject: Fixed XML format of the log messages response

---
 .../src/get_volume_brick_log.py                            | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

(limited to 'src/com.gluster.storage.management.server.scripts')

diff --git a/src/com.gluster.storage.management.server.scripts/src/get_volume_brick_log.py b/src/com.gluster.storage.management.server.scripts/src/get_volume_brick_log.py
index 64a40df3..fd7361da 100755
--- a/src/com.gluster.storage.management.server.scripts/src/get_volume_brick_log.py
+++ b/src/com.gluster.storage.management.server.scripts/src/get_volume_brick_log.py
@@ -44,10 +44,12 @@ def enumLogType(logCode):
         return "UNKNOWN"
 ##--end of enumLogType()
 
-def addLog(responseDom, loginfo):
-    responseDom.appendTagRoute("logMessages.logMessage.timestamp", loginfo[0] + " " + loginfo[1])
-    responseDom.appendTagRoute("logMessages.logMessage.severity", enumLogType(loginfo[2]))
-    responseDom.appendTagRoute("logMessages.logMessage.message", loginfo[3])
+def addLog(responseDom, logMessagesTag, loginfo):
+    logMessageTag = responseDom.createTag("logMessage")
+    logMessageTag.appendChild(responseDom.createTag("timestamp", loginfo[0] + " " + loginfo[1]))
+    logMessageTag.appendChild(responseDom.createTag("severity", enumLogType(loginfo[2])))
+    logMessageTag.appendChild(responseDom.createTag("message", loginfo[3]))
+    logMessagesTag.appendChild(logMessageTag);
     return True
 ##--end of addLog()
 
@@ -79,9 +81,11 @@ def getVolumeLog(logFilePath, tailCount):
     i = len(lines) - int(tailCount)
     if i < 0:
         i = 0
+    logMessagesTag = rs.createTag("logMessages")
+    rs.addTag(logMessagesTag)
     for log in lines[i:]:
         loginfo = logSplit(log)
-        addLog(rs, loginfo)
+        addLog(rs, logMessagesTag, loginfo)
     return rs.toxml()
 ##--end of getVolumeLog()
 
-- 
cgit