From 4ce909b825305b2bbc41c666e95e55c4ceceb002 Mon Sep 17 00:00:00 2001 From: Jilju Joy Date: Sat, 22 Jun 2019 11:18:10 +0530 Subject: Removing redundant method 'run_refresh_config' The method 'refresh_config' can be used instead of 'run_refresh_config' Change-Id: I6c70b4dff1fd4531fdf6eaa4f044d2d1992d8151 Signed-off-by: Jilju Joy --- .../glustolibs/gluster/nfs_ganesha_ops.py | 51 ---------------------- 1 file changed, 51 deletions(-) (limited to 'glustolibs-gluster/glustolibs') diff --git a/glustolibs-gluster/glustolibs/gluster/nfs_ganesha_ops.py b/glustolibs-gluster/glustolibs/gluster/nfs_ganesha_ops.py index 476db2d09..3e53ec29d 100644 --- a/glustolibs-gluster/glustolibs/gluster/nfs_ganesha_ops.py +++ b/glustolibs-gluster/glustolibs/gluster/nfs_ganesha_ops.py @@ -282,57 +282,6 @@ def unexport_nfs_ganesha_volume(mnode, volname): return g.run(mnode, cmd) -def run_refresh_config(mnode, volname): - """Runs refresh config on nfs ganesha volume. - - Args: - mnode (str): Node in which refresh config command will - be executed. - volname (str): volume name - - Returns: - bool : True on successfully running refresh config on - nfs-ganesha volume. False otherwise - - Example: - run_refresh_config("abc.com", volname) - """ - - conf_file = "nfs_ganesha_refresh_config.jinja" - gdeploy_config_file = GDEPLOY_CONF_DIR + conf_file - - tmp_gdeploy_config_file = ("/tmp/" + os.path.splitext(conf_file)[0] + - ".conf") - - values_to_substitute_in_template = {'server': mnode, - 'volname': volname} - - ret = g.render_template(gdeploy_config_file, - values_to_substitute_in_template, - tmp_gdeploy_config_file) - if not ret: - g.log.error("Failed to substitute values in %s file" - % tmp_gdeploy_config_file) - return False - - cmd = "gdeploy -c " + tmp_gdeploy_config_file - retcode, stdout, stderr = g.run_local(cmd) - if retcode != 0: - g.log.error("Failed to execute gdeploy cmd %s for running " - "refresh config on nfs ganesha volume" % cmd) - g.log.error("gdeploy console output for running refresh config " - "on nfs ganesha volume: %s" % stderr) - - return False - - g.log.info("gdeploy output for running refresh config " - "on nfs ganesha volume: %s" % stdout) - - # Removing the gdeploy conf file from /tmp - os.remove(tmp_gdeploy_config_file) - return True - - def update_volume_export_configuration(mnode, volname, config_to_update): """Updates volume export configuration and runs refresh config for the volume. -- cgit