From 86d16d2a98af540ba458721edc2ac8a530c01635 Mon Sep 17 00:00:00 2001 From: kshithijiyer Date: Wed, 8 Jan 2020 15:53:31 +0530 Subject: [py2to3] Change str to list in isinstance() Use 'list' object type in comparisons instead of 'str' Because it is differently treated in py2 and py3. Example: In py2 isinstance(u'foo', str) is False In py3 isinstance(u'foo', str) is True Change-Id: I7663d42494bf59d74550ff4897379d35cc357db4 Signed-off-by: kshithijiyer --- glustolibs-gluster/glustolibs/gluster/volume_ops.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'glustolibs-gluster/glustolibs/gluster/volume_ops.py') diff --git a/glustolibs-gluster/glustolibs/gluster/volume_ops.py b/glustolibs-gluster/glustolibs/gluster/volume_ops.py index 0b3c94b..9bc8649 100644 --- a/glustolibs-gluster/glustolibs/gluster/volume_ops.py +++ b/glustolibs-gluster/glustolibs/gluster/volume_ops.py @@ -573,7 +573,7 @@ def set_volume_options(mnode, volname, options): # Check if group options are specified. if 'group' in volume_options: group_options = volume_options.pop('group') - if isinstance(group_options, str): + if not isinstance(group_options, list): group_options = [group_options] for group_option in group_options: cmd = ("gluster volume set %s group %s --mode=script" % -- cgit v1.1