diff options
author | Bala Konda Reddy M <bala12352@gmail.com> | 2020-08-17 16:11:38 +0530 |
---|---|---|
committer | Bala Konda Reddy M <bala12352@gmail.com> | 2020-08-18 05:58:43 +0000 |
commit | 81440d1bab4d43785b37d285877b235ddd9ac6b6 (patch) | |
tree | 890ba5879f4188b4ee46ad897c443e1c55a7f903 /tests/functional/authentication/test_auth_invalid_values.py | |
parent | 891472d8b77574dbb3346b98bb0948e0f2d12a2c (diff) |
[Testfix] Remove redundant logging - Part 1
Problem:
In most of the testcases due to redundant logging,
the performance of the whole suite completion time
is affected.
Solution:
Currently there are 100+ g.log.info statements in the
authentincation suite and half of them are redundant.
Removed the g.log.info statements whereever it is not
required. After the changes the g.log.info statements
are around 50 and not removed the statements to reduce
the number of lines but for the improvement of the
whole suite.
Modified few line indents as well and added teardown
for the missing files.
Note: Will be submitting for each components separately
Change-Id: I63973e115dd5dbbc7fc9462978397e7915181265
Signed-off-by: Bala Konda Reddy M <bala12352@gmail.com>
Diffstat (limited to 'tests/functional/authentication/test_auth_invalid_values.py')
-rw-r--r-- | tests/functional/authentication/test_auth_invalid_values.py | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/tests/functional/authentication/test_auth_invalid_values.py b/tests/functional/authentication/test_auth_invalid_values.py index 7fd514b71..a494c8357 100644 --- a/tests/functional/authentication/test_auth_invalid_values.py +++ b/tests/functional/authentication/test_auth_invalid_values.py @@ -27,9 +27,8 @@ from glustolibs.gluster.volume_ops import set_volume_options from glustolibs.gluster.volume_libs import is_volume_exported -@runs_on([['replicated', 'distributed', 'distributed-replicated', - 'dispersed', 'distributed-dispersed'], - ['glusterfs', 'nfs']]) +@runs_on([['replicated', 'distributed', 'distributed-replicated', 'dispersed', + 'distributed-dispersed'], ['glusterfs', 'nfs']]) class AuthInvalidValues(GlusterBaseClass): """ Tests to verify negative scenario in authentication allow and reject @@ -42,13 +41,10 @@ class AuthInvalidValues(GlusterBaseClass): """ cls.get_super_method(cls, 'setUpClass')() # Create and start volume - g.log.info("Starting volume setup process %s", cls.volname) ret = cls.setup_volume() if not ret: raise ExecutionError("Failed to setup " "and start volume %s" % cls.volname) - g.log.info("Successfully created and started the volume: %s", - cls.volname) def set_invalid_auth(self, auth_opt, values_list): """ @@ -157,8 +153,9 @@ class AuthInvalidValues(GlusterBaseClass): """ Cleanup volume """ - g.log.info("Cleaning up volume") ret = self.cleanup_volume() if not ret: raise ExecutionError("Failed to cleanup volume.") - g.log.info("Volume cleanup was successful.") + + # Calling GlusterBaseClass tearDown + self.get_super_method(self, 'tearDown')() |