summaryrefslogtreecommitdiffstats
path: root/doc/developer-guide/Fixing-issues-reported-by-tools-for-static-code-analysis.md
blob: 5a3dceb7d0e78cb253f27906dfbcac120639440d (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
Static Code Analysis Tools
--------------------------

Bug fixes for issues reported by *Static Code Analysis Tools* should
follow [Development Work Flow](./Development Workflow.md)

### Coverity

GlusterFS is part of [Coverity's](https://scan.coverity.com/) scan
program.

-   To see Coverity issues you have to be a member of the GlusterFS
    project in Coverity scan website.
-   Here is the link to [Coverity scan
    website](https://scan.coverity.com/projects/987)
-   Go to above link and subscribe to GlusterFS project (as
    contributor). It will send a request to Admin for including you in
    the Project.
-   Once admins for the GlusterFS Coverity scan approve your request,
    you will be able to see the defects raised by Coverity.
-   [BZ 789278](https://bugzilla.redhat.com/show_bug.cgi?id=789278)
    should be used as a umbrella bug for Coverity issues in master
    branch unless you are trying to fix a specific bug in Bugzilla.
    -   While sending patches for fixing Coverity issues please use the
        same bug number.
    -   For 3.6 branch the Coverity tracking bug is
        [1122834](https://bugzilla.redhat.com/show_bug.cgi?id=1122834)
-   When you decide to work on some issue, please assign it to your name
    in the same Coverity website. So that we don't step on each others
    work.
-   When marking a bug intentional in Coverity scan website, please put
    an explanation for the same. So that it will help others to
    understand the reasoning behind it.

*If you have more questions please send it to
[gluster-devel](http://www.gluster.org/interact/mailinglists) mailing
list*

### CPP Check

Cppcheck is available in Fedora and EL's EPEL repo

-   Install Cppcheck

        yum install cppcheck

-   Clone GlusterFS code

        git clone https://github.com/gluster/glusterfs) glusterfs

-   Run Cpp check

        cppcheck glusterfs/ 2>cppcheck.log

-   [BZ 1091677](https://bugzilla.redhat.com/show_bug.cgi?id=1091677)
    should be used for submitting patches to master branch for Cppcheck
    reported issues.

### Daily Runs

We now have daily runs of various static source code analysis tools on
the glusterfs sources. There are daily analyses of the master,
release-3.6, and release-3.5 branches.

Results are posted at
<http://download.gluster.org/pub/gluster/glusterfs/static-analysis/>