From f9ed9b87b74fa5868187f3743d04d105b921c510 Mon Sep 17 00:00:00 2001 From: Soumya Koduri Date: Thu, 6 Oct 2016 13:13:44 +0530 Subject: md-cache: Invalidate cache entry for open() with O_TRUNC When a file is opened with O_TRUNC flag set, its size gets set to '0'. This case needs to be handled in md-cache to avoid sending incorrect cached stat. This is backport of below mainline patch - http://review.gluster.org/#/c/15618/ > Change-Id: I95d1f8a6634734898883ede010c3e7b0b7eb97d9 > BUG: 1382266 > Signed-off-by: Soumya Koduri > Reviewed-on: http://review.gluster.org/15618 > Smoke: Gluster Build System > Reviewed-by: jiffin tony Thottan > Tested-by: jiffin tony Thottan > NetBSD-regression: NetBSD Build System > CentOS-regression: Gluster Build System > Reviewed-by: Kaleb KEITHLEY > (cherry picked from commit 6ca5d6382f03685b31b12accb095093cf1486603) Change-Id: I00d2b0a6dbafa690235bbc7cd714ec7cc8a13808 BUG: 1391451 Signed-off-by: Soumya Koduri Reviewed-on: http://review.gluster.org/15772 NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Smoke: Gluster Build System Reviewed-by: Kaleb KEITHLEY --- xlators/performance/md-cache/src/md-cache.c | 48 +++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) (limited to 'xlators') diff --git a/xlators/performance/md-cache/src/md-cache.c b/xlators/performance/md-cache/src/md-cache.c index 74aafdbd8d0..5f3cc0141f7 100644 --- a/xlators/performance/md-cache/src/md-cache.c +++ b/xlators/performance/md-cache/src/md-cache.c @@ -1511,6 +1511,53 @@ mdc_create (call_frame_t *frame, xlator_t *this, loc_t *loc, int flags, } +static int +mdc_open_cbk (call_frame_t *frame, void *cookie, xlator_t *this, + int32_t op_ret, int32_t op_errno, fd_t *fd, + dict_t *xdata) +{ + mdc_local_t *local = NULL; + + local = frame->local; + + if (op_ret || !local) + goto out; + + if (local->fd->flags & O_TRUNC) { + /* O_TRUNC modifies file size. Hence invalidate the + * cache entry to fetch latest attributes. */ + mdc_inode_iatt_invalidate (this, local->fd->inode); + } + +out: + MDC_STACK_UNWIND (open, frame, op_ret, op_errno, fd, xdata); + return 0; +} + + +static int +mdc_open (call_frame_t *frame, xlator_t *this, loc_t *loc, int flags, + fd_t *fd, dict_t *xdata) +{ + mdc_local_t *local = NULL; + + if (!fd || !IA_ISREG(fd->inode->ia_type) || + !(fd->flags & O_TRUNC)) { + goto out; + } + + local = mdc_local_get (frame); + + local->fd = fd_ref (fd); + +out: + STACK_WIND (frame, mdc_open_cbk, + FIRST_CHILD(this), FIRST_CHILD(this)->fops->open, + loc, flags, fd, xdata); + return 0; +} + + int mdc_readv_cbk (call_frame_t *frame, void *cookie, xlator_t *this, int32_t op_ret, int32_t op_errno, @@ -2390,6 +2437,7 @@ struct xlator_fops fops = { .rename = mdc_rename, .link = mdc_link, .create = mdc_create, + .open = mdc_open, .readv = mdc_readv, .writev = mdc_writev, .setattr = mdc_setattr, -- cgit