From 8daaac1481adc919cb80c6f3d98bc5b3f0b829f5 Mon Sep 17 00:00:00 2001 From: Kamal Mohanan Date: Mon, 25 Sep 2017 12:07:03 +0530 Subject: dht: fix a coverity error of type - UNREACHABLE Problem: Unreachable assignment statement at dht-rebalance.c:1040 Fix: Delete line dht-rebalance.c:1040. The goto statements at lines 1037 and 1031 are also deleted since both branches of the if statement finally go to the same immediately-following label anyway. Change-Id: I5f47ea99244cae2a0a9f2aec7284faadf2ea286a BUG: 789278 Signed-off-by: Kamal Mohanan --- xlators/cluster/dht/src/dht-rebalance.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'xlators') diff --git a/xlators/cluster/dht/src/dht-rebalance.c b/xlators/cluster/dht/src/dht-rebalance.c index b81be03404c..e932eaa3add 100644 --- a/xlators/cluster/dht/src/dht-rebalance.c +++ b/xlators/cluster/dht/src/dht-rebalance.c @@ -1028,16 +1028,13 @@ find_new_subvol: *target_changed = _gf_false; *fop_errno = ENOSPC; ret = -1; - goto out; } else { gf_msg (this->name, GF_LOG_INFO, 0, 0, "new target found - %s" " for file - %s", (*new_subvol)->name, loc->path); *target_changed = _gf_true; ret = 0; - goto out; } - ret = 0; out: if (xdata) dict_unref (xdata); -- cgit