From 6f037c46c2a015cad37430fd18052bbf6bfffc5c Mon Sep 17 00:00:00 2001 From: Avra Sengupta Date: Fri, 10 Jun 2016 16:33:04 +0530 Subject: tiering/ctr: Fix strcpy coverity This patch is without a testcase, because it needs additional modification to the existing build method to hit the scenario this fix is intended for, and hence writing a testcase alone won't suffice. Backport of http://review.gluster.org/#/c/14696/ > Reviewed-on: http://review.gluster.org/14696 > Reviewed-by: mohammed rafi kc > Smoke: Gluster Build System > NetBSD-regression: NetBSD Build System > Reviewed-by: N Balachandran > CentOS-regression: Gluster Build System > Reviewed-by: Dan Lambright (cherry picked from commit 3474aa85e399a92d3ee9159a2d066d4bd73611a0) Change-Id: I6cffba3e09a023f105dbf2975cc9a3ae1a965c31 BUG: 1346133 Signed-off-by: Avra Sengupta Reviewed-on: http://review.gluster.org/14721 Smoke: Gluster Build System NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Reviewed-by: Vijay Bellur --- xlators/features/changetimerecorder/src/changetimerecorder.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'xlators') diff --git a/xlators/features/changetimerecorder/src/changetimerecorder.c b/xlators/features/changetimerecorder/src/changetimerecorder.c index 95ce08fea2b..b6ff18934fe 100644 --- a/xlators/features/changetimerecorder/src/changetimerecorder.c +++ b/xlators/features/changetimerecorder/src/changetimerecorder.c @@ -126,8 +126,9 @@ ctr_lookup_wind(call_frame_t *frame, /* Copy hard link info*/ gf_uuid_copy (CTR_DB_REC(ctr_local).pargfid, *((NEW_LINK_CX(ctr_inode_cx))->pargfid)); - strcpy (CTR_DB_REC(ctr_local).file_name, - NEW_LINK_CX(ctr_inode_cx)->basename); + strncpy (CTR_DB_REC(ctr_local).file_name, + NEW_LINK_CX(ctr_inode_cx)->basename, + sizeof(CTR_DB_REC(ctr_local).file_name)); /* Since we are in lookup we can ignore errors while * Inserting in the DB, because there may be many -- cgit