From 6e3efac008e564c4d76a17c32a272bbfb89edd27 Mon Sep 17 00:00:00 2001 From: Krishnan Parthasarathi Date: Mon, 17 Dec 2012 18:13:17 +0530 Subject: features/locks: fcntl(3) on F_GETLK must return first conflicting lock - Added test program, getlk_owner.c to capture the bug when regressed. Change-Id: Id6055a1e64609b9701560e50a9767f387ddadce7 BUG: 869724 Signed-off-by: Krishnan Parthasarathi Reviewed-on: https://code.engineering.redhat.com/gerrit/1993 Reviewed-by: Vijay Bellur Tested-by: Vijay Bellur --- xlators/features/locks/src/common.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) (limited to 'xlators') diff --git a/xlators/features/locks/src/common.c b/xlators/features/locks/src/common.c index af03cdf2a7a..9883859a075 100644 --- a/xlators/features/locks/src/common.c +++ b/xlators/features/locks/src/common.c @@ -725,6 +725,28 @@ done: return v; } +static posix_lock_t * +first_conflicting_overlap (pl_inode_t *pl_inode, posix_lock_t *lock) +{ + posix_lock_t *l = NULL; + + list_for_each_entry (l, &pl_inode->ext_list, list) { + if (l->blocked) + continue; + + if (locks_overlap (l, lock)) { + if (same_owner (l, lock)) + continue; + + if ((l->fl_type == F_WRLCK) || + (lock->fl_type == F_WRLCK)) + return l; + } + } + + return NULL; +} + /* Start searching from {begin}, and return the first lock that conflicts, NULL if no conflict @@ -1066,7 +1088,7 @@ pl_getlk (pl_inode_t *pl_inode, posix_lock_t *lock) { posix_lock_t *conf = NULL; - conf = first_overlap (pl_inode, lock); + conf = first_conflicting_overlap (pl_inode, lock); if (conf == NULL) { lock->fl_type = F_UNLCK; -- cgit