From 57d2ba0582010a45fa286e22ad4b9e2a6e3d3bae Mon Sep 17 00:00:00 2001 From: Niels de Vos Date: Fri, 27 Feb 2015 23:47:26 +0100 Subject: nfs: prevent logging missing 'system.posix_acl_access' xattrs Change http://review.gluster.org/9773 addresses the majority of the logging, but it seems it is still possible to trigger the excessive logging by requesting the ACL on files directly. Lets squash those too. Change-Id: Iced2b90997a6172655797c9bb7bf2a682814371d BUG: 1197598 Signed-off-by: Niels de Vos Reviewed-on: http://review.gluster.org/9829 Tested-by: Gluster Build System Reviewed-by: Kaleb KEITHLEY Reviewed-by: Raghavendra Bhat --- xlators/nfs/server/src/acl3.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'xlators') diff --git a/xlators/nfs/server/src/acl3.c b/xlators/nfs/server/src/acl3.c index 3ffbd4a690e..09923a07631 100644 --- a/xlators/nfs/server/src/acl3.c +++ b/xlators/nfs/server/src/acl3.c @@ -271,6 +271,10 @@ acl3_getacl_cbk (call_frame_t *frame, void *cookie, xlator_t *this, if ((op_ret < 0) && (op_errno != ENODATA && op_errno != ENOATTR)) { stat = nfs3_cbk_errno_status (op_ret, op_errno); goto err; + } else if (!dict) { + /* no ACL has been set */ + stat = NFS3_OK; + goto err; } getaclreply->aclentry.aclentry_val = cs->aclentry; -- cgit