From 5384787d41d33916521fdda194875a306f406eeb Mon Sep 17 00:00:00 2001 From: Raghavendra Bhat Date: Fri, 7 Sep 2018 14:00:59 -0400 Subject: features/snapview-server: remove the ret variable Used only once to store the return value of a function. Change-Id: Ib2b9db847b5f652ce46f220297d9c7c3503eaea2 fixes: #230 Signed-off-by: Raghavendra Bhat --- xlators/features/snapview-server/src/snapview-server.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'xlators') diff --git a/xlators/features/snapview-server/src/snapview-server.c b/xlators/features/snapview-server/src/snapview-server.c index 664889b4a16..4d32eb0beef 100644 --- a/xlators/features/snapview-server/src/snapview-server.c +++ b/xlators/features/snapview-server/src/snapview-server.c @@ -323,7 +323,6 @@ svs_lookup_entry (xlator_t *this, loc_t *loc, struct iatt *buf, svs_inode_t *inode_ctx = NULL; glfs_object_t *parent_object = NULL; uuid_t gfid = {0, }; - int ret = -1; GF_VALIDATE_OR_GOTO ("snapview-server", this, out); @@ -367,13 +366,12 @@ svs_lookup_entry (xlator_t *this, loc_t *loc, struct iatt *buf, if (gf_uuid_is_null (loc->gfid) && gf_uuid_is_null (loc->inode->gfid)) { - ret = svs_uuid_generate (this, gfid, parent_ctx->snapname, - object->gfid); + if (svs_uuid_generate (this, gfid, parent_ctx->snapname, + object->gfid)) { /* * should op_errno be something else such as * EINVAL or ESTALE? */ - if (ret) { op_ret = -1; *op_errno = EIO; goto out; -- cgit